Bug 400344 - Notifications Plugin Disable All Does Nothing
Summary: Notifications Plugin Disable All Does Nothing
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: android-application (other bugs)
Version First Reported In: 1.10
Platform: Android Android 8.x
: NOR normal
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-26 15:00 UTC by Simon Redman
Modified: 2018-10-31 10:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:
simon: corner_case+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Redman 2018-10-26 15:00:30 UTC
SUMMARY
The notifications plugin All setting appears to work for enabling notifications for all apps, but does not work to disable all notifications

STEPS TO REPRODUCE
Case 1: Disable all apps
1. Open notifications plugin settings
2. Double-click "All" checkbox - One click to enable all, one click to disable all
3. Close notifications settings

Case 2: Enable a few apps which were previously enabled
1. Open notifications plugin settings
2. Double-click "All" checkbox - One click to enable all, one click to disable all
3. Scroll through the list and enable some apps which were previously *enabled*
4. Close notifications settings

Case 3: Enable a few apps which were previously disabled
1. Open notifications plugin settings
2. Double-click "All" checkbox - One click to enable all, one click to disable all
3. Scroll through the list and enable some apps which were previously *disabled*
4. Close notifications settings

OBSERVED RESULT
Case 1:
On reopening the notifications plugin settings, nothing has changed

Case 2:
On reopening the notifications plugin settings, nothing has changed

Case 3:
Any apps which were previously disabled and were enabled after de-selecting all are now enabled, all other apps remain untouched

EXPECTED RESULT
Case 1:
All apps should be disabled

Case 2:
All apps except those selected should be disabled

Case 3:
All apps except those selected should be disabled


SOFTWARE VERSIONS
App v1.10, built from master, commit hash cbd4af23783db873f221c327df554fd79d53946b

ADDITIONAL INFORMATION
Comment 1 Albert Vaca Cintora 2018-10-31 10:06:13 UTC
Fixed in commit https://commits.kde.org/kdeconnect-android/10cecab65cd788538871bdd97f5c8f49fd169af6