Bug 400335 - Elisa doesn't provide Global menu
Summary: Elisa doesn't provide Global menu
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 0.3.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-26 13:29 UTC by trmdi
Modified: 2022-12-31 19:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description trmdi 2018-10-26 13:29:58 UTC
The title says it all, please make Elisa support Global menu.
Otherwise, it looks a bit ugly on setups that use macOS/unity layout with Global menu.
Comment 1 Matthieu Gallien 2019-05-03 20:25:38 UTC
Are you able to do a test ?
I have created https://phabricator.kde.org/D21006 to implement that.
Comment 2 Matthieu Gallien 2019-09-10 15:21:59 UTC
Git commit 7d815c9fa3803f06d592d9885fa8bf6031d51b7e by Matthieu Gallien.
Committed on 10/09/2019 at 15:20.
Pushed by mgallien into branch 'master'.

Add global menu by using qml native menu components

Summary:
Seems to do the job by providing a global menu and not clutering the UI
when plasma-workspace does not provide a global menu.

Test Plan: Works with Plasma 5.14 and a global menu applet

Reviewers: #elisa, ngraham

Reviewed By: #elisa, ngraham

Subscribers: trmdi

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D21006

M  +1    -0    src/CMakeLists.txt
M  +6    -0    src/qml/ElisaMainWindow.qml
A  +112  -0    src/qml/NativeApplicationMenu.qml     [License: LGPL (v3+)]
M  +1    -0    src/resources.qrc

https://commits.kde.org/elisa/7d815c9fa3803f06d592d9885fa8bf6031d51b7e
Comment 3 Mickaël Leduque 2022-12-31 19:59:30 UTC
Hi,
I can't find where I can configure it to show the global menu, I only have a hamburger menu, and the "configure elisa" dialog doesn't show anything that tells it will show a menu instead of a hamburger ?