Bug 400312 - Installed snaps don't have an icon
Summary: Installed snaps don't have an icon
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Snap Backend (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-25 22:46 UTC by Patrick Silva
Modified: 2019-08-06 14:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.62


Attachments
screenshot (326.93 KB, image/png)
2018-10-25 22:46 UTC, Patrick Silva
Details
list of installed snaps (191.31 KB, image/png)
2018-10-25 22:55 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-10-25 22:46:18 UTC
Created attachment 115902 [details]
screenshot

STEPS TO REPRODUCE
1. open Discover and search for something, let's say "photos"
2. 
3. 

OBSERVED RESULT
Snap packages listed in the search results have wrong icon.
The icon is correct in their description page.
See the screenshot.

EXPECTED RESULT
Snaps have correct icon in the search results.

KDE neon Developer Edition
KDE Plasma: 5.14.80
Qt: 5.11.2
KDE Frameworks: 5.52.0
Comment 1 Patrick Silva 2018-10-25 22:55:22 UTC
Created attachment 115903 [details]
list of installed snaps

icons are also wrong in the list of installed Snaps under "Settings".
Comment 2 Aleix Pol 2018-10-26 00:04:19 UTC
First one is already fixed in kirigami master. The second isn't so I'll rename the bug.
Comment 3 Aleix Pol 2019-08-06 13:42:58 UTC
Git commit 19d09d1ef958b68b8de56965b97d647cfe4ea7b6 by Aleix Pol.
Committed on 06/08/2019 at 13:42.
Pushed by apol into branch 'master'.

Kirigami.Icon: Fix loading bigger images when source is a URL

Summary:
Port to using the QImage::load() that takes a QIODevice and only do it when the
execution is finished, instead of upon readyRead(). This makes sure that we are
only processing the icon when is fully downloaded.
Related: bug 407409

Test Plan: Reproduced the bug and fixed it

Reviewers: #frameworks, #kirigami, mart

Reviewed By: #kirigami, mart

Subscribers: broulik, plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D22952

M  +36   -42   src/icon.cpp
M  +2    -2    src/icon.h

https://commits.kde.org/kirigami/19d09d1ef958b68b8de56965b97d647cfe4ea7b6