Bug 400303 - Search results list only shows you top-level categories rather than the actual matched items
Summary: Search results list only shows you top-level categories rather than the actua...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: sidebarview (show other bugs)
Version: 5.14.1
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords: usability
: 395432 410182 412059 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-10-25 16:08 UTC by S
Modified: 2019-12-20 13:33 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.0


Attachments
"compositor" search shows "Display and Monitor" entry, which opens "Compositor" (71.33 KB, image/png)
2018-10-25 16:08 UTC, S
Details

Note You need to log in before you can comment on or make changes to this bug.
Description S 2018-10-25 16:08:54 UTC
Created attachment 115897 [details]
"compositor" search shows "Display and Monitor" entry, which opens "Compositor"

Hi there, in Plasma 5.14.1 on openSUSE Tumbleweed, a search for "compositor" shows the "Display and Monitor" item instead of the "Compositor" item, although "Compositor" is opened when clicking the "Display and Monitor" entry.
Comment 1 S 2018-10-25 16:10:30 UTC
BTW, I believe that this bug is a new regression in Plasma 5.14.1, as I was playing with Compositor settings in 5.13.x and 5.14.0 and never noticed this behavior.
Comment 2 Nate Graham 2018-10-25 17:32:57 UTC
It is actually finding the Compositor KCM, but what's going on here is that the search results list only shows you top-level categories rather than the actual matched items. It probably should.
Comment 3 S 2018-10-25 17:48:38 UTC
(In reply to Nate Graham from comment #2)
> It is actually finding the Compositor KCM, but what's going on here is that
> the search results list only shows you top-level categories rather than the
> actual matched items. It probably should.

Yep, that's what I expected. It's rather confusing, and at first I thought that it wasn't locating the Compositor module at all.
Comment 4 Nate Graham 2019-07-25 13:31:31 UTC
*** Bug 395432 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2019-07-25 13:31:36 UTC
*** Bug 410182 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2019-09-19 20:37:29 UTC
*** Bug 412059 has been marked as a duplicate of this bug. ***
Comment 7 Marco Martin 2019-12-20 13:33:25 UTC
Git commit f82cca0cb07fb34e185ef8fe8d4503442c8f0308 by Marco Martin.
Committed on 20/12/2019 at 13:33.
Pushed by mart into branch 'master'.

Display sub categories when searching

Summary:
when searching, show categories *and* subcategories indented
under categories, making it way less confusing

when the user clicks at a search result the proper
category and subcategory will open

Also when clicking on most used, the proper
category/subcategory will get open on the
sidebar
Related: bug 398619
FIXED-IN: 5.18.0

Test Plan:
{F7819885}
Also old views icons and tree still work as usual

Reviewers: #plasma, #vdg, davidedmundson

Reviewed By: #plasma, #vdg, davidedmundson

Subscribers: ngraham, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26021

M  +1    -0    CMakeLists.txt
M  +35   -7    core/MenuModel.cpp
M  +20   -10   core/MenuModel.h
M  +6    -0    core/MenuProxyModel.cpp
M  +1    -0    sidebar/CMakeLists.txt
M  +173  -121  sidebar/SidebarMode.cpp
M  +35   -14   sidebar/SidebarMode.h
M  +12   -2    sidebar/ToolTips/tooltipmanager.cpp
M  +4    -1    sidebar/ToolTips/tooltipmanager.h
M  +50   -13   sidebar/package/contents/ui/CategoriesPage.qml
M  +1    -1    sidebar/package/contents/ui/IntroIcon.qml
M  +28   -9    sidebar/package/contents/ui/SubCategoryPage.qml
M  +2    -0    sidebar/package/contents/ui/main.qml

https://commits.kde.org/systemsettings/f82cca0cb07fb34e185ef8fe8d4503442c8f0308