Bug 400292 - cruft in plasma-desktop tars
Summary: cruft in plasma-desktop tars
Status: RESOLVED FIXED
Alias: None
Product: releaseme
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Harald Sitter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-25 13:45 UTC by Rik Mills
Modified: 2019-01-08 13:26 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/releaseme/ec11313a92b58bb24e33e95173132bef4244631b
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Mills 2018-10-25 13:45:09 UTC 
SUMMARY

Releaseme includes unwanted files in with .po files for some localisations in plasma-desktop tars.

STEPS TO REPRODUCE
1. Upload a plasma-desktop tar to Ubuntu as a SRU
2. Wait for Ubuntu release team to review and process the upload

OBSERVED RESULT

Observe the rejection email received stating that that the upload has binary and other 'cruft'

EXPECTED RESULT

No cruft, and upload accepted (unless you otherwise screwed up).

ADDITIONAL INFORMATION

On a serious note, seems to have been the cruft in released tars since plasma 5.10, so this is quite late being picked up!

Example listing from 5.12.7:

plasma-desktop-5.12.7/kcms/autostart/addscriptdialog.cpp
plasma-desktop-5.12.7/kcms/autostart/addscriptdialog.h
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/kfontinst/
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/kfontinst/kfontinst.js
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/kfontinst/.svn/
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/kfontinst/.svn/entries
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/kfontinst/.svn/format
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/kfontinst/.svn/pristine/
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/kfontinst/.svn/pristine/5a/
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/kfontinst/.svn/pristine/5a/5a626e01c24fb40324448dba9b875a77c0be9990.svn-base
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/kfontinst/.svn/tmp/
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/kfontinst/.svn/wc.db
plasma-desktop-5.12.7/po/sr@ijekavianlatin/scripts/kfontinst/.svn/wc.db-journal
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/kfontinst/
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/kfontinst/kfontinst.js
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/kfontinst/.svn/
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/kfontinst/.svn/entries
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/kfontinst/.svn/format
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/kfontinst/.svn/pristine/
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/kfontinst/.svn/pristine/1d/
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/kfontinst/.svn/pristine/1d/1db547f1e3e22e03e2ec6163ece3bde6afd2eaf2.svn-base
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/kfontinst/.svn/tmp/
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/kfontinst/.svn/wc.db
plasma-desktop-5.12.7/po/sr@ijekavian/scripts/kfontinst/.svn/wc.db-journal
plasma-desktop-5.12.7/po/sr@latin/scripts/
plasma-desktop-5.12.7/po/sr@latin/scripts/kfontinst/
plasma-desktop-5.12.7/po/sr@latin/scripts/kfontinst/kfontinst.js
plasma-desktop-5.12.7/po/sr@latin/scripts/kfontinst/.svn/
plasma-desktop-5.12.7/po/sr@latin/scripts/kfontinst/.svn/entries
plasma-desktop-5.12.7/po/sr@latin/scripts/kfontinst/.svn/format
plasma-desktop-5.12.7/po/sr@latin/scripts/kfontinst/.svn/pristine/
plasma-desktop-5.12.7/po/sr@latin/scripts/kfontinst/.svn/pristine/5a/
plasma-desktop-5.12.7/po/sr@latin/scripts/kfontinst/.svn/pristine/5a/5a626e01c24fb40324448dba9b875a77c0be9990.svn-base
plasma-desktop-5.12.7/po/sr@latin/scripts/kfontinst/.svn/tmp/
plasma-desktop-5.12.7/po/sr@latin/scripts/kfontinst/.svn/wc.db
plasma-desktop-5.12.7/po/sr@latin/scripts/kfontinst/.svn/wc.db-journal
plasma-desktop-5.12.7/po/sr/scripts/
plasma-desktop-5.12.7/po/sr/scripts/kfontinst/
plasma-desktop-5.12.7/po/sr/scripts/kfontinst/kfontinst.js
plasma-desktop-5.12.7/po/sr/scripts/kfontinst/.svn/
plasma-desktop-5.12.7/po/sr/scripts/kfontinst/.svn/entries
plasma-desktop-5.12.7/po/sr/scripts/kfontinst/.svn/format
plasma-desktop-5.12.7/po/sr/scripts/kfontinst/.svn/pristine/
plasma-desktop-5.12.7/po/sr/scripts/kfontinst/.svn/pristine/1d/
plasma-desktop-5.12.7/po/sr/scripts/kfontinst/.svn/pristine/1d/1db547f1e3e22e03e2ec6163ece3bde6afd2eaf2.svn-base
plasma-desktop-5.12.7/po/sr/scripts/kfontinst/.svn/tmp/
plasma-desktop-5.12.7/po/sr/scripts/kfontinst/.svn/wc.db
plasma-desktop-5.12.7/po/sr/scripts/kfontinst/.svn/wc.db-journal
Comment 1 Harald Sitter 2018-10-25 14:36:30 UTC 
Lol 5.10

I suspect the "new" script download tech doesn't properly clean up after itself. It may be prudent to actually add a global cleanup before archiving. Relying on individual units to clean up is somewhat unreliable as we can see. OTOH I am sure I had a reason for doing it this way.
Comment 2 Harald Sitter 2019-01-08 13:26:22 UTC 
Git commit ec11313a92b58bb24e33e95173132bef4244631b by Harald Sitter.
Committed on 08/01/2019 at 13:26.
Pushed by sitter into branch 'master'.

don't leave dangling .svn directories

the l10n downloaders never cleaned their checkouts properly. for the time
being we'll simply drop them immediately since we do no extra fiddling
with svn anyway, so there is no reason to keep them.

the two tests now assert that there is no .svn anywhere in the po dir

M  +4    -3    lib/releaseme/l10n/data_downloader.rb
M  +2    -2    lib/releaseme/l10n/script_downloader.rb
M  +10   -1    test/l10n_test.rb

https://commits.kde.org/releaseme/ec11313a92b58bb24e33e95173132bef4244631b