Bug 400291 - SFTP kio slave no longer built
Summary: SFTP kio slave no longer built
Status: RESOLVED FIXED
Alias: None
Product: kio-extras
Classification: Frameworks and Libraries
Component: SFTP (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Andreas Schneider
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-25 13:41 UTC by Kai Uwe Broulik
Modified: 2018-10-31 10:24 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2018-10-25 13:41:07 UTC
The SFTP kio slave is no longer built as it doesn't find libssh and I don't see how this could have ever worked.
Comment 1 Andreas Schneider 2018-10-25 16:00:41 UTC
Which version of libssh do you have installed and do you have the devel package?
Comment 2 Kai Uwe Broulik 2018-10-26 07:50:20 UTC
$ apt-cache policy libssh-dev
libssh-dev:
  Installed: 0.8.0~20170825.94fa1e38-1ubuntu0.1
Comment 3 Andreas Schneider 2018-10-26 09:34:41 UTC
Is that packaged git version or why does it have a date in the version number? I would suggest to move to libssh 0.8.4 (security release).

libssh provides cmake config files:

rpm -ql libssh-devel | grep cmake
/usr/lib64/cmake/libssh
/usr/lib64/cmake/libssh/libssh-config-version.cmake
/usr/lib64/cmake/libssh/libssh-config.cmake

rpm -q libssh-devel
libssh-devel-0.8.4-1.1.x86_64
Comment 4 Kai Uwe Broulik 2018-10-26 11:03:00 UTC
I have no idea, there's also no cmake stuff in there, just pkconfig.
Comment 5 Kai Uwe Broulik 2018-10-26 11:56:59 UTC
Likely a packaging bug, reported to Ubuntu [1]. In the meantime I would suggest to restore the LibSSH find module or ship a copy of the current one.

[1] https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1800135
Comment 6 Harald Sitter 2018-10-31 10:24:07 UTC
Git commit 0e129b10ae30bd985ce1e38d50deb23a685f095c by Harald Sitter.
Committed on 31/10/2018 at 10:23.
Pushed by sitter into branch 'master'.

make libssh module default to the "new" libssh config by default

Summary:
- rename module from LibSSH to libssh so casing is consistent with config
- module now quietly attempts to find libssh by config and returns if found
- if it was not found we'll fall back to manual lookup
- adjust actual FOUND variable use for correct case
- fix package case in properties set up (this is case sensitive)

this is singularly necessary because the config file is not correctly
packaged in ubuntu 18.04 (LTS)

https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1800135/comments/2

This reverts 3b1fd6bd8866da2dadd33705af53613236503efc.

Test Plan: builds in ubuntu docker container and with a system that has a proper config

Reviewers: broulik, asn

Reviewed By: broulik

Subscribers: kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D16529

M  +3    -3    CMakeLists.txt
A  +113  -0    cmake/Findlibssh.cmake

https://commits.kde.org/kio-extras/0e129b10ae30bd985ce1e38d50deb23a685f095c