Bug 400235 - New settings module design has wrong text alignment with certain widget styles
Summary: New settings module design has wrong text alignment with certain widget styles
Status: RESOLVED DOWNSTREAM
Alias: None
Product: dolphin
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-24 13:11 UTC by Filip Fila
Modified: 2018-10-24 16:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Fila 2018-10-24 13:11:11 UTC
SUMMARY
The redesign of the Settings module was made with the idea of aligning the text of a certain option so that all the ":" are horizontally in the same position. This does not happen with certain widget styles, instead the text is left aligned. 

The following widget styles are affected: Kvantum, Fusion, MS Windows 9x, qt5ct-style
The unaffected ones are: Breeze, QtCurve, Oxygen

Example: https://i.imgur.com/aM05zl1.png

Unfortunately the same is present with other redesigns and these widget styles, but I will probably have to investigate more and file separate bugs for that.

STEPS TO REPRODUCE
1. Open the Dolphin settings page with the aforementioned widget styles. 

OBSERVED RESULT
Text is not aligned properly, as is the case with unaffected widget styles.

EXPECTED RESULT
Text is aligned properly in all widget styles. 

SOFTWARE VERSIONS
KDE Plasma Version: 5.14.1
KDE Frameworks Version: 5.51
Qt Version: 5.11.2
Comment 1 Nate Graham 2018-10-24 14:12:19 UTC
The label alignment is determined automatically by the style; we don't choose or override it in the code at all. So this is a problem with those widget styles, not Dolphin.
Comment 2 Filip Fila 2018-10-24 16:55:42 UTC
Kvantum bug reported here: https://github.com/tsujan/Kvantum/issues/280

People who use other widget styles can give it a shot with the people who maintain them, should they be bothered by the alignment.