Bug 400083 - [Wayland] A message containing huge icon appears when I press ctrl+alt+esc and a thirdy-part icon theme is used
Summary: [Wayland] A message containing huge icon appears when I press ctrl+alt+esc an...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: wayland-generic (other bugs)
Version First Reported In: 5.14.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 400084 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-10-20 23:50 UTC by Patrick Silva
Modified: 2018-10-26 11:14 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
screenshot (2.36 MB, image/jpeg)
2018-10-20 23:50 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-10-20 23:50:27 UTC
Created attachment 115789 [details]
screenshot

SUMMARY
icon theme is newaita, installed from kde store.

STEPS TO REPRODUCE
1. start Wayland session
2. press ctrl+alt+esc
3. 

OBSERVED RESULT
a message containing a huge icon shows up. See the screenshot.

EXPECTED RESULT
normal icon size

SOFTWARE VERSIONS
Sistema operacional: Arch Linux 
Versão do KDE Plasma: 5.14.1
Versão da Qt: 5.12.0 beta2
Versão do KDE Frameworks: 5.51.0

ADDITIONAL INFORMATION
Also reproducible on neon dev unstable.
Cannot reproduce when icon theme is breeze or breeze dark.
Comment 1 Nate Graham 2018-10-21 00:12:43 UTC
*** Bug 400084 has been marked as a duplicate of this bug. ***
Comment 2 Nate Graham 2018-10-21 00:13:19 UTC
The icons in question are high-resolution raster icons, not vector icons.
Comment 3 Alexander Mentyu 2018-10-22 09:25:08 UTC
Can't reproduce this bug - cross icons appears in center of screen with normal size - installed Newaita.tar.gz from GHNS

Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.14.80
Qt Version: 5.11.1
KDE Frameworks Version: 5.52.0
Comment 4 David Edmundson 2018-10-26 00:09:15 UTC
And this only happens on the wayland session?
Comment 5 David Edmundson 2018-10-26 00:19:05 UTC
It'll be more fallout from the p-f change a while back to make IconItem::implicitWidth be based on the icon size. 

Something that in hindsight was a mistake.

Will fix.
Comment 6 Patrick Silva 2018-10-26 00:25:21 UTC
(In reply to David Edmundson from comment #4)
> And this only happens on the wayland session?

yes. No message appears when I press the shorcut on X11.
Comment 7 David Edmundson 2018-10-26 11:14:18 UTC
Git commit 110fa039cbf8e7f414d8db7d4a68102d8fd9420f by David Edmundson.
Committed on 26/10/2018 at 11:13.
Pushed by davidedmundson into branch 'master'.

Use consistent size icon in OSD

Summary:
The OSD's icon is based on the implicitSize of the IconItem.

For most icons this will be a hardcoded value from
KIconLoader::global()->currentSize

However, since bc33f0470d4d6bcbf30475f85b36705e8a99528b in
plasma-framework we sometimes return that value, sometimes will return the
source size of the underlying image depending on internal paths of how
the icon is loaded and whether it was in the plasma theme or not.

This patch overrides the implicitWidth given to the layout to be the
standard icon size.

Test Plan:
Loaded the force kill window OSD.
Icon still looked the same size on breeze.

I didn't reproduce the issue in the bug

Reviewers: #kwin, graesslin

Reviewed By: #kwin, graesslin

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16432

M  +2    -2    qml/onscreennotification/plasma/main.qml

https://commits.kde.org/kwin/110fa039cbf8e7f414d8db7d4a68102d8fd9420f