Bug 399888 - Missing icon in "Configure..." button
Summary: Missing icon in "Configure..." button
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Weather (show other bugs)
Version: 5.14.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Friedrich W. H. Kossebau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-16 16:49 UTC by Patrick Silva
Modified: 2018-10-18 12:53 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.14.2


Attachments
screenshot (9.00 KB, image/png)
2018-10-16 16:49 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-10-16 16:49:01 UTC
Created attachment 115681 [details]
screenshot

STEPS TO REPRODUCE
1. add weather report widget to your desktop
2. 
3. 

OBSERVED RESULT
See my screenshot please. On top is weather report, on bottom is media frame widget. "Configure..." button of weather report has no icon.

EXPECTED RESULT
"Configure..." button of the weather report widget should have the same icon as the button of the media frame widget.

SOFTWARE VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.14.1
Qt Version: 5.11.2
KDE Frameworks Version: 5.51.0
Comment 1 Nate Graham 2018-10-17 23:12:11 UTC
Have a patch: https://phabricator.kde.org/D16287
Comment 2 Nate Graham 2018-10-18 12:53:20 UTC
Git commit bd558d122885aa7119a5acc2f787e868c2436100 by Nate Graham.
Committed on 18/10/2018 at 12:51.
Pushed by ngraham into branch 'master'.

[Comics & Weather widgets] give "Configure..." buttons icons

Summary:
This patch gives the Comics and Weather widgets appropriate icons for their {nav Configure...} buttons.
FIXED-IN: 5.14.2

Test Plan:
{F6335981}
(Weather on top, Comics on bottom)

Note that the size discrepancy appears to be an unrelated `PlasmaComponents3` bug: https://bugs.kde.org/show_bug.cgi?id=399952 (The Weather widget uses PC3, while the Comics widget uses PC2)

Reviewers: #plasma, kossebau, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16287

M  +1    -0    applets/comic/package/contents/ui/main.qml
M  +1    -0    applets/weather/package/contents/ui/FullRepresentation.qml

https://commits.kde.org/kdeplasma-addons/bd558d122885aa7119a5acc2f787e868c2436100