For some versions now okular marks a document as modified (* in title) after adding annotations, and allows to safe these to the document file.
If the file is a symlink, "save" does not add the annotations to the original file (as I'd expect), but copies the file and replaces the symlink with the now annotated file, leaving me with to versions & copies of the file.
KDE Plasma Version: 5.14.0
KDE Frameworks Version: 5.50.0
Qt Version: 5.11.2
Whoops! That's not great.
Git commit 99fe8fa6cfa7741351844f70fb86ff297378e4c2 by Albert Astals Cid.
Committed on 22/10/2018 at 19:41.
Pushed by aacid into branch 'Applications/18.08'.
Resolve symlinks before saving so we don't "break" them
Summary: BUGS: 399870
Reviewed By: ngraham
Subscribers: shubham, ngraham, okular-devel
Differential Revision: https://phabricator.kde.org/D16364
M +9 -5 part.cpp
I am not able to save any file after this patch! Please check.
Works for me. How did you apply the patch?
I am not sure what you mean? I apply all the patches on 18.08 git
and rebuild okular rpm for my system. When I remove this I can save
again. Do you have all the patches applied?
Please attach a screen recording showing the problem.
Created attachment 115859 [details]
Thanks, that's helpful. I found that error while reviewing the patch, and Albert fixed it already before the patch landed. I wonder if there is some corner case we're hitting.
Are you trying to save a PDF with annotations, or doing File > Save As... to save the PDF in a different location?
No annotations but I am doing Save as...to save it to my home directory.
It appears in /tmp/mozilla_umar0/ by default. It would be nice if one
tries to save it defaults to home directory.
This is why I asked for a screen recording (not a screenshot). It would be much easier to see what you're doing to trigger the bug.
Do I understand correctly that you
1. Downloaded a PDF file from Firefox
2. ...and it wound up in /tmp/mozilla_umar0/
3. ...and how you want to save it to a location in your home folder?
Exactly...I configured firefox to open pdf using okular.
OK, will test and report back.
Just commited a fix for that regression.
Thanks for signaling it :)
That fixes it!