Bug 399808 - Dragging an image file into wallpaper picker dialog shows an "not allowed" cursor
Summary: Dragging an image file into wallpaper picker dialog shows an "not allowed" cu...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image & Slideshow wallpaper plugins (show other bugs)
Version: master
Platform: Gentoo Packages Linux
: NOR minor
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2018-10-14 18:23 UTC by acidrums4
Modified: 2019-06-23 16:24 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description acidrums4 2018-10-14 18:23:41 UTC
SUMMARY
I remember not long agou you couldn't drag an image file (say, from Dolphin) into the wallpaper picker to be able to choose it as a wallpaper.

That was fixed but I just recently noticed that, because there is a tiny caveat: while dragging the image file over the wallpaper picker dialog/widget, it will turn the cursor as a "not-allowed" one - but still, if you release the image file there, it will appear as a new option to set a wallpaper.

For the sake of usability, I think not only the cursor thing should be fixed (and changed to a default cursor), but there should be some sort of feedback about the ability of that wallpaper picker widget for receiving dragged image files, so users can know they're doing something the widget is able to do - for example, highlighting the widget, turning its background color to a 'selected' or 'highlighted' colour, or something like that.

STEPS TO REPRODUCE
1. Right-click your desktop and select "Configure desktop" and select "Desktop wallpaper". It should be configured as "Slideshow" or "Still image" (this happens on those two cases; I don't know how all those buttons and things are actually named in english Plasma releases).
2. Pick an image from your file browser and drag them to the wallpaper widget (the area where available wallpaper images are shown).

OBSERVED RESULT
Cursor is turned to a "not-allowed" state while dragging an image file over it.

EXPECTED RESULT
Cursor should keep its "default" state, or something that lets the user know they can drag image files into it. Also, some sort of feedback from the widget should reinforce that idea on users so they can be sure they're doing something allowed and when they can release the image so the widget will catch it (highlighting the widget area, for example).
Comment 1 Nate Graham 2019-06-14 22:36:34 UTC
Seems to be fixed as of Plasma 5.15.5 and 5.16.
Comment 2 acidrums4 2019-06-17 12:39:32 UTC
(In reply to Nate Graham from comment #1)
> Seems to be fixed as of Plasma 5.15.5 and 5.16.

I updated to 5.16 last week and tried it (it was time to change to a new wallpaper) - still the same thing...
Comment 3 Nate Graham 2019-06-17 12:42:38 UTC
I don't see that in 5.16. Can you attach a screen recording that shows the issue?
Comment 4 acidrums4 2019-06-23 16:24:32 UTC
(In reply to Nate Graham from comment #3)
> I don't see that in 5.16. Can you attach a screen recording that shows the
> issue?

Sorry for being late, busy at work. Here you go.

https://streamable.com/1joo1

BUT you were right - it's fixed... on X11. As I'm already using Wayland as daily diver I hadn't noticed this was fixed for X11. But alas this won't work on Wayland - I can't even record the screen under there, so I can't show you how it goes (pretty much the same, but instead of a "plus" cursor you got a "not-allowed" one).

I still do think (apart that this should be fixed for Wayland) that a visual feedback, other than the "plus" cursor (not only here, but say for example, dragging a text file from Dolphin to Kate), would be awesome.https://streamable.com/1joo1

Thank you