Tried to build it with Qt 5.6, and got this compiler error: /home/abuild/rpmbuild/BUILD/kphotoalbum-5.4/ThumbnailView/ThumbnailDND.cpp: In member function 'void ThumbnailView::ThumbnailDND::contentsDragMoveEvent(QDragMoveEvent*)': /home/abuild/rpmbuild/BUILD/kphotoalbum-5.4/ThumbnailView/ThumbnailDND.cpp:58:69: error: 'class QRegion' has no member named 'cbegin' if ( ( event->pos().y() > widget()->viewport()->visibleRegion().cbegin()->height() - 10 ) ) ^ From the Qt docs: QRegion::const_iterator QRegion::cbegin() const Same as begin(). This function was introduced in Qt 5.8.
Hi Wolfgang! Thanks for the bug report (and also for the patch you posted on Phabricator). With the new release, we decided to drop support for Qt <5.8. As it's necessary to maintain extra code (de)activated via #ifdef blocks to support older versions, it means that we would have to raise additional manpower to maintain it (and as it's probably the case for most OSS projects, we don't have too much of it ;-) Additionally, even Debian (we all know for not having bleeding edge versions) has Qt 5.9, as well as the current LTS versions of Ubuntu (at least as far as we know). Thus, we thought the userbase still being depenant on Qt < 5.8 should be small, and it would be okay to clean up some old code. After all, it's also simply a proctical problem: It's quite hard for us to even test compatibility with old Qt versions. No offense! And thanks for your effort for sure! Cheers, Tobias
Fair enough. I didn't know that support for Qt < 5.8 was dropped on purpose because there's no minimum version specified in CMakeLists.txt nor in the README (the release announcement was not online yet). Should probably be changed I think, to avoid such "confusion". I suppose I should withdraw https://phabricator.kde.org/D16192 then... I'm going to use that patch though to provide kphotoalbum 5.4 for openSUSE Leap 42.3 (which ships with Qt 5.6.2, and is still supported for about half a year) as well.
I mentionned it in the release announcement, but I wrote it yesterday – one day after tagging (mostly that's because I also did releases and the release announcement at the same time and then we got bugs about the sources not being available, because the mirrors weren't synced yet). But you're completely right, we should include a Qt version check in the CMakeLists.txt. I'll fix this! Thanks for the hint :-)
Git commit 613e7846c03c7e3a72263d237679833a949e9195 by Johannes Zarl-Zierl. Committed on 15/10/2018 at 19:15. Pushed by johanneszarl into branch 'master'. Express version dependencies in build system. M +2 -2 CMakeLists.txt https://commits.kde.org/kphotoalbum/613e7846c03c7e3a72263d237679833a949e9195