Created attachment 115555 [details] Backtrace SUMMARY When I click a reference image to select it, I get a segfault. I'm attaching a backtrace. It happens in my build from today morning. In previous build from Tuesday it worked. STEPS TO REPRODUCE 1. Switch to reference image tool. 2. Click a reference image to select it. OBSERVED RESULT Segfault. EXPECTED RESULT Selected image.
Comment on attachment 115555 [details] Backtrace Doesn't seem to crash here...
Hey again, Anna. I haven't been able to reproduce this one so far. Can you give me any more details? For example, does it seem to happen every time or only occasionally? #0 0x00007fffbb891330 in SelectionDecorator::isOverTextEditorButton() (this=0x0) at /home/tilya/programy/krita/src/gamut-masking/plugins/tools/defaulttool/defaulttool/SelectionDecorator.cpp:243 #1 0x00007fffbb8809d4 in DefaultTool::updateCursor() (this=this@entry=0x55555747b950) at /home/tilya/programy/krita/src/gamut-masking/plugins/tools/defaulttool/defaulttool/DefaultTool.cpp:646 rotOctant = <optimized out> rotateHandle = false shearHandle = false editable = true cursor = {d = 0x555557366590} statusText = {d = 0x7ffff4f14620 <QArrayData::shared_null>} selection = <optimized out> It may be due to the fact that SelectionDecorator::isOverTextEditorButton() is being called without first being null-checked, but until I can reproduce the crash myself I can only guess. Thanks for the report.
Also switching this bug to "waitingforinfo" for now.
Git commit 193a608f4741043d9dc24e0a160df9ec2d1b01d9 by Dmitry Kazakov. Committed on 11/10/2018 at 08:12. Pushed by dkazakov into branch 'master'. Fix a crash when selecting reference image with default tool M +1 -1 plugins/tools/defaulttool/defaulttool/DefaultTool.cpp https://commits.kde.org/krita/193a608f4741043d9dc24e0a160df9ec2d1b01d9
I lost the race...