Bug 399613 - user-trash should not look like a folder at large sizes
Summary: user-trash should not look like a folder at large sizes
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
: 411516 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-10-10 14:23 UTC by Nate Graham
Modified: 2019-09-03 13:57 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.62


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-10-10 14:23:49 UTC
Right now the `user-trash` icon looks like a trash can at small sizes but starts looking like a folder with a trash icon in it at large sizes. This is undesirable; the trash is really not something to be thought of as a folder. We should make its large size stop looking like a folder. Instead, it should be a pretty full-color Breeze-style trash can.
Comment 1 Andrew Crouthamel 2018-10-10 14:27:54 UTC
+1 Yes please. This was an issue I ran into a while ago when doing work for Gwenview.
Comment 2 Noah Davis 2018-10-17 20:07:39 UTC
(In reply to Nate Graham from comment #0)
> Right now the `user-trash` icon looks like a trash can at small sizes but
> starts looking like a folder with a trash icon in it at large sizes. This is
> undesirable; the trash is really not something to be thought of as a folder.
> We should make its large size stop looking like a folder. Instead, it should
> be a pretty full-color Breeze-style trash can.

I thought the trash was a folder? If that is not how it works, then I agree. If it is a folder, then I think the icon should stay a folder.
Comment 3 Ivan Čukić 2018-10-17 20:13:53 UTC
> I thought the trash was a folder?

Even if it was, that is a technicality. The icon should reflect what it is used as, and it is not used as a normal folder.
Comment 4 Nate Graham 2018-10-17 20:17:46 UTC
(In reply to Ivan Čukić from comment #3)
> > I thought the trash was a folder?
> 
> Even if it was, that is a technicality. The icon should reflect what it is
> used as, and it is not used as a normal folder.

Exactly.
Comment 5 Nate Graham 2019-09-02 13:28:10 UTC
*** Bug 411516 has been marked as a duplicate of this bug. ***
Comment 6 Noah Davis 2019-09-03 13:55:04 UTC
Git commit d970e61493a6ff648350e8cf53a19372c9847505 by Noah Davis.
Committed on 03/09/2019 at 13:54.
Pushed by ndavis into branch 'master'.

Make user-trash icons look like trashcans

Summary: BUG: 399613

Test Plan:
{F7309835, size=full}

{F7309836, size=full}

Reviewers: #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23685

M  +56   -23   icons-dark/places/32/user-trash-full.svg
M  +40   -23   icons-dark/places/32/user-trash.svg
M  +56   -23   icons-dark/places/64/user-trash-full.svg
M  +40   -23   icons-dark/places/64/user-trash.svg
M  +56   -23   icons/places/32/user-trash-full.svg
M  +40   -23   icons/places/32/user-trash.svg
M  +56   -23   icons/places/64/user-trash-full.svg
M  +40   -23   icons/places/64/user-trash.svg

https://commits.kde.org/breeze-icons/d970e61493a6ff648350e8cf53a19372c9847505