Bug 399575 - layer remains visible after undo of creation
Summary: layer remains visible after undo of creation
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: 4.1.3
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-09 19:24 UTC by wkg28406
Modified: 2018-10-11 08:23 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description wkg28406 2018-10-09 19:24:04 UTC
SUMMARY
When undoing creation of a layer with content on it, it remains visible.

STEPS TO REPRODUCE
1. New document
2. Draw on Layer 2
3. Duplicate Layer 2
4. Hide Layer 2 (eye in docker)
5. Undo

OBSERVED RESULT
Duplicated layer is still visible even though it is removed and no other layers except Layer 1 are visible.

EXPECTED RESULT
No layers should be visible except Layer 1.

SOFTWARE VERSIONS
Qt Version: 5.11.2-1

ADDITIONAL INFORMATION
This was just one method. Layers do not have to be hidden nor does it have to be a duplicated layer.

Here's another example which shows some other issues with layers: (and how it was originally discovered)
1. New document
2. Draw something on Layer 2
3. Create new Layer 3
4. Draw on new Layer 3
5. Delete Layer 3
6. Draw something on Layer 2 (cannot do next steps unless this is done, deletion not added to undo stack)
7. Undo twice
8. Redo
Comment 1 Emmet O'Neill 2018-10-10 09:36:15 UTC
Git commit 20406f0cb05f81cfa5f752d9c6b43f1ebc1a476f by Emmet O'Neill.
Committed on 10/10/2018 at 09:35.
Pushed by emmetoneill into branch 'master'.

Fix KisImageLayerAddCommand Redo/Undo Updating Bug.

M  +1    -1    libs/ui/kis_node_juggler_compressed.cpp

https://commits.kde.org/krita/20406f0cb05f81cfa5f752d9c6b43f1ebc1a476f
Comment 2 Halla Rempt 2018-10-11 08:23:20 UTC
Git commit 0b5a8d344ff8509ddae44461a444db9df2221258 by Boudewijn Rempt, on behalf of Emmet O'Neill.
Committed on 11/10/2018 at 07:52.
Pushed by rempt into branch 'krita/4.1'.

Fix KisImageLayerAddCommand Redo/Undo Updating Bug.
(cherry picked from commit 20406f0cb05f81cfa5f752d9c6b43f1ebc1a476f)

M  +1    -1    libs/ui/kis_node_juggler_compressed.cpp

https://commits.kde.org/krita/0b5a8d344ff8509ddae44461a444db9df2221258