Created attachment 115444 [details] Hebrew text and some alignment issues Some parts of the Krita interface are badly alligned (RTL) or showing Hebrew text despite the application language being set to English. STEPS TO REPRODUCE I have Windows 10 x64. The language is English. The locale is Hebrew (I tried changing it, it did not affect Krita) Location is Israel Language list includes Hebrew and English. I have not managed to pinpoint the system-setting that causes Krita to act this way. I'll be happy to provide any additional information if I know what to look for. OBSERVED RESULT As visible in the attached screenshots - the menus look a bit out-of-sorts. With alignment issues & some Hebrew text. EXPECTED RESULT The menus should appear identical to those visible on English-only systems.
Created attachment 115445 [details] Label placement issues
Created attachment 115446 [details] Misaligned menu text and parentheses
Git commit b68419b0395002d9043da6bacc2a7510bbce3844 by Boudewijn Rempt. Committed on 08/10/2018 at 08:43. Pushed by rempt into branch 'master'. Check whether the override language is RTL or LTR If we have an override language, Qt doesn't accept that, even though we set the entire environment correctly. This means we get translated dialog box buttons, but we cannot do anything about that. This attempts to at least fix the application layout. M +25 -10 krita/main.cc https://commits.kde.org/krita/b68419b0395002d9043da6bacc2a7510bbce3844
Hi Tamir, Could you please check with the next nightly windows build (#314) to see whether my hack fixes the layout issues for you? I cannot test myself, because if I set my desktop to hebrew or any other RTL language, I won't be able to set it back to something I can read... https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/
I'll check the nightly build when it completes. As for the translated buttons - there is an easy workaround for that. Removing the `he` directory from `Krita (x64)/bin/locale` prevents the translation.
If I understand the Qt code, that should even prevent the RTL/LTR confusion, and if it doesn't, Qt is even weirder than I thought :-)
I checked with the #314 nightly (https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/314/). There is no change. The menus are misaligned and the Hebrew is showing. Removing the `he` locale directory only removes the translation, and does not fix the alignment.
Dash it... Maybe I should add a manual override option then.
Hi Tamir Is this still an issue? If you're still facing it please provide more information. I might test as well (using a RTL locale, Arabic)
Looks like it's mostly resolved now. Some placements are still iffy, but I think it's mostly due to lack of translations.
Can you show what you mean by screenshots?
Created attachment 129741 [details] Properly aligned parens You can see that the parentheses are now properly aligned. The rest looks the same. The questions is - where a translation is missing for a specific part - should it be flipped for RTL, or kept as LTR?
Removing assigned tag as commit hasn't fixed the issue.
Do not change the status of bugs, Justin.
Please recheck with 5.0, I think it should be fixed?
Setting to needsinfo, since it needs someone with the appropriate locale to check with the latest release.
Sorry for the long delay on my part. I tested now (Krita 5.1.1) and it seems to work as expected!
Yay, thanks for testing!!!
Thanks for your comment! Automatically switching the status of this bug to REPORTED so that the KDE team knows that the bug is ready to get confirmed. In the future you may also do this yourself when providing needed information.