Bug 399423 - Regressions with glide effect
Summary: Regressions with glide effect
Status: RESOLVED NOT A BUG
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (show other bugs)
Version: 5.13.90
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-05 22:55 UTC by Lucas
Modified: 2018-10-24 07:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas 2018-10-05 22:55:34 UTC
There are some undesirable differences with the earlier version:


1 - Currently it's too similar with the scale effect. The window should appear/disappear from an infinite distance perspective. 

2 - Default is too fast.

3 - When the max distance is chosen, the window still seem to appear from a close distance and not 100% transparent. It's not smooth.

4 - Same when max negative distance is chosen, it's not smooth

5 - It's not clear in the settings what the max and min values are. A slider is more adequate.
Comment 1 Vlad Zahorodnii 2018-10-06 09:44:51 UTC
(In reply to Lucas from comment #0)
> There are some undesirable differences with the earlier version:
I wouldn't call them undesirable. The old Glide effect had some problems with
being too much distracting (especially, when you're working with programs that
are dialog-heavy). To fix that, the Glide effect was rewritten to make it more
subtler, fix some serious issues on multiple monitor setups, and to make it
possible to have different animations when opening and closing windows (it doesn't
look good when you close a window and it rotates around its top edge).

So, I wouldn't call differences between the old and the new effect as regressions.

> 1 - Currently it's too similar with the scale effect. The window should
> appear/disappear from an infinite distance perspective. 
In that case, the effect will become distracting in long term, so I'm against it.
If I get more complaints about that, I'll increase initial angles by several degrees
and maybe make the Scale effect slightly less subtler by decreasing initial scales,
but that's pretty much it.

Yes, the Glide effect and the Scale effect are slightly similar (because in both
cases, animated windows grow in size, and both effects are subtle), but after using
each of them for a long period of time, the difference becomes more noticeable.

> 3 - When the max distance is chosen, the window still seem to appear from a
> close distance and not 100% transparent. It's not smooth.
In the old version of the effect, we were scaling windows. In the rewritten one,
we're animating z-coordinate of the window. Because of that, you won't be able
to get precisely old glide effect.

> 4 - Same when max negative distance is chosen, it's not smooth
What do you mean by "it's not smooth"?

> 5 - It's not clear in the settings what the max and min values are. A slider
> is more adequate.
Hmm, yeah, maybe. (Please file for this issue a separate bug report)
Comment 2 Lucas 2018-10-24 05:38:49 UTC
I've tested on non-nvidia hardware and it's smoother now, it's only when choosing  max negative distance that the animation becomes choppy, see https://streamable.com/ybj0v

> In that case, the effect will become distracting in long term, so I'm against it.
> If I get more complaints about that, I'll increase initial angles by several degrees and maybe make the Scale effect slightly less subtler by decreasing initial scales,but that's pretty much it.

> Yes, the Glide effect and the Scale effect are slightly similar (because in both cases, animated windows grow in size, and both effects are subtle), but after using each of them for a long period of time, the difference becomes more noticeable.

I agree that the effect becomes really distracting with those edge rotations, I always set the angle to 0. But the glide effect is in essence a fancy effect, as it was inspired by the compiz equivalent, see https://www.youtube.com/watch?v=dYZg3Y2cpj4 
and I think it should stay as it was (most people don't tweak effects to see it's capabilities, they just want to turn it on to see what happens), and maybe those who want a subtler effect could use the "Scale" one.

> Hmm, yeah, maybe. (Please file for this issue a separate bug report)

Done :)
Comment 3 Vlad Zahorodnii 2018-10-24 07:34:04 UTC
(In reply to Lucas from comment #2)
> I agree that the effect becomes really distracting with those edge
> rotations, I always set the angle to 0.
In that case, please use the Scale effect, not the Glide effect. The whole
purpose of the Glide effect is to rotate windows (+ move them towards
the user).

> But the glide effect is in essence a fancy effect, as it was inspired
> by the compiz equivalent, see https://www.youtube.com/watch?v=dYZg3Y2cpj4 
> and I think it should stay as it was (most people don't tweak effects to see
> it's capabilities, they just want to turn it on to see what happens), and
> maybe those who want a subtler effect could use the "Scale" one.
... and the Glide effect from Compiz was inspired by window open/close
animation from Vista... I'm sorry, but the Glide effect will stay as it is.
Comment 4 Vlad Zahorodnii 2018-10-24 07:35:49 UTC
Also, fwiw, you can use scale factors > 1 in the Scale effect.