Created attachment 115429 [details] debug SUMMARY When renaming multiple files and another file of same name exists and selecting Rename Again or Cancel results in crash STEPS TO REPRODUCE 1. Select multiple files to rename (using '[meta:Exif.Photo.DateTimeOriginal]' to rename and then select files again and use '[file]{replace:"_","",ri}{trim}{range:1,15}{unique}{replace:" ","_",ri}' to remove the _ and space and add unique in case of pictures taken at same time with two different cameras) OBSERVED RESULT Digikam renames as usual until a file with same name is encountered Choice is given to rename again, overwrite or cancel, when rename again or cancel are selected digikam hangs then quits. EXPECTED RESULT File to rename or add unique value to it. SOFTWARE VERSIONS DK 6 build Oct 2 (mysql internal, mariadb-10.3.10-winx64) Windows 10 ADDITIONAL INFORMATION Also using on a folder that is set for Google Backup and Sync
Git commit 6bba3f447aa3ee11924e08529ccdde1fad5ad557 by Maik Qualmann. Committed on 05/10/2018 at 16:50. Pushed by mqualmann into branch 'master'. we do not need the ImageViewUtilities here M +1 -2 core/app/items/imageviewutilities.cpp M +8 -1 core/libs/database/utils/dio.cpp M +1 -1 core/libs/database/utils/dio.h M +3 -7 core/utilities/advancedrename/advancedrenameprocessdialog.cpp https://commits.kde.org/digikam/6bba3f447aa3ee11924e08529ccdde1fad5ad557
I can not reproduce the problem on Linux or Windows. But maybe we had a double deletion of a class here. We will see it with the next update. Maik
Dave, The bundles are under compilation stages. All will be uploaded in one hour at usual place and ready to test last changes done by Maik. Files will be uploaded here : https://files.kde.org/digikam/ Gilles Caulier
You guys are awesome, I will report back when I get a chance to download and test. Dave Brown
I can now reproduce the problem with the current Windows build on a real Windows7 machine. Maik
Git commit fa42aa4944270cc225102efeff41f813a53a63b8 by Maik Qualmann. Committed on 11/10/2018 at 17:23. Pushed by mqualmann into branch 'master'. next attempt to fix the crash in the rename dialog M +2 -1 core/utilities/advancedrename/advancedrenameprocessdialog.cpp https://commits.kde.org/digikam/fa42aa4944270cc225102efeff41f813a53a63b8
Also this commit does not fix it... Maik
With the gdb on Windows the problem becomes clear, I fix it... Maik
Ok sorry for the delay, I have had a chance to test out the commit from 10-6 and it does the same except I can select cancel and go back without a crash. When new commit is updated I will test out and report back. Dave Brown
Maik, I plan to release the beta 2 while this weekend as all sound fine with Exiv2 0.27 everywhere. Do you want to wait to close this file with or not ? Gilles
I fix the bug today. Maik
Git commit 81fb8a0160d55851d3a2f8b49d0afba2e53e65ae by Maik Qualmann. Committed on 12/10/2018 at 17:12. Pushed by mqualmann into branch 'master'. fix finish signal from Advanced Rename thread FIXED-IN: 6.0.0 M +2 -1 NEWS M +3 -2 core/libs/database/utils/dio.cpp M +1 -1 core/libs/database/utils/dio.h M +20 -29 core/utilities/advancedrename/advancedrenameprocessdialog.cpp M +1 -1 core/utilities/advancedrename/advancedrenameprocessdialog.h https://commits.kde.org/digikam/81fb8a0160d55851d3a2f8b49d0afba2e53e65ae
Thank you guys, works as expected now.