Bug 399394 - Links in Community column on Krita's new welcome screen are not aligned properly under Windows
Summary: Links in Community column on Krita's new welcome screen are not aligned prope...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-05 01:39 UTC by Tyson Tan
Modified: 2018-10-15 02:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Links in Community column on Krita new welcome screen are not aligned properly under Windows (185.95 KB, image/png)
2018-10-05 01:39 UTC, Tyson Tan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2018-10-05 01:39:54 UTC
Created attachment 115422 [details]
Links in Community column on Krita new welcome screen are not aligned properly under Windows

SUMMARY
Links in Community column on Krita's new welcome screen are not aligned properly under Windows.
Tested under Windows 10 1803/1809 with krita-nightly-x64-v4.1.3.1-51-gd66f43616a-setup.exe

STEPS TO REPRODUCE
1. Open Krita and look at the Community column links under Windows
2. And compare that with those under Linux
3. 

OBSERVED RESULT
The links seem to aligned to center with an strange axis. I don't know what it is using as reference.

EXPECTED RESULT
The links should be aligned to left like they are under Linux.

SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Halla Rempt 2018-10-05 07:20:15 UTC
the problem is that the links are implemented as buttons instead of a label like in the splash screen. Scott, can you remember why you made them buttons?
Comment 2 Scott Petrovic 2018-10-06 12:33:56 UTC
Git commit 17ed5faab21566ce8d2289831809dfa3d75b5287 by Scott Petrovic.
Committed on 06/10/2018 at 12:32.
Pushed by scottpetrovic into branch 'master'.

M  +42   -46   libs/ui/KisWelcomePageWidget.cpp
M  +0    -12   libs/ui/KisWelcomePageWidget.h
M  +32   -79   libs/ui/forms/KisWelcomePage.ui

https://commits.kde.org/krita/17ed5faab21566ce8d2289831809dfa3d75b5287
Comment 3 Scott Petrovic 2018-10-06 13:13:51 UTC
I originally didn't think that hard about it...and it looked ok on my dev machine (Ubuntu) so I didn't think to update it...which is why they were all buttons previously.

All the URLs on the right are QLabels now. For the New and Open buttons, I am having a hard time getting those to work with a QLabel. The normal press and click signals either don't exist or aren't working for it with my attempts. QLabel has special functionality if it is a URL, but seems to have issues for me if I try to do normal connection stuff like mousePress or click signals.
Comment 4 Tyson Tan 2018-10-15 02:07:43 UTC
Thank you Scott! :)