Bug 399354 - Wallpaper preview does not take into account screen rotation
Summary: Wallpaper preview does not take into account screen rotation
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image & Slideshow wallpaper plugins (show other bugs)
Version: 5.13.5
Platform: Debian testing Linux
: NOR minor
Target Milestone: 1.0
Assignee: Iaroslav
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2018-10-03 23:04 UTC by Alex
Modified: 2021-11-09 18:14 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24
Sentry Crash Report:


Attachments
wallpaper preview (246.56 KB, image/png)
2018-10-03 23:48 UTC, Alex
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2018-10-03 23:04:03 UTC
SUMMARY
When changing the desktop wallpaper on a rotated screen, the wallpaper preview is not rotated, leading to an incorrect preview.

STEPS TO REPRODUCE
1. Rotate your screen in 90 degrees in either direction.
2. Right click on the desktop and choose "Configure Desktop".
3. Add an image with an aspect ratio matching the rotated screen.
4. Choose scaled positioning.

OBSERVED RESULT
The preview image is stretched horizontally as the preview box does not respect screen rotation. 

EXPECTED RESULT
The preview image is not stretched, as no stretching occurs when applying the wallpaper to the rotated screen.

SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 5.13.5
KDE Frameworks Version: 5.49.0
Qt Version: 5.11.1
Comment 1 Alex 2018-10-03 23:48:04 UTC
Created attachment 115395 [details]
wallpaper preview

Actually, there's an easier recipe:

1. Rotate your screen by 90 degrees.
2. Go to "Configure Desktop".
3. Add an image with a portrait aspect ratio.
4. Choose centered positioning with a different background colour than the wallpaper.

I've attached a picture with an example of this.
Comment 2 Bug Janitor Service 2021-10-20 01:17:12 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1132
Comment 3 Aleix Pol 2021-11-09 18:01:34 UTC
Git commit f2afc13d6b3adb439c0571695ecd1e68d63b6a5f by Aleix Pol Gonzalez, on behalf of Iaroslav Sheveliuk.
Committed on 09/11/2021 at 17:55.
Pushed by ngraham into branch 'master'.

Wallpaper preview should respect the screen aspect ratio

Wallpaper thumbnails was using the landscape orientation all the time.
Now thumbnail size depends on the screen size, so aspect ratio is respected.

M  +5    -0    wallpapers/image/imagepackage/contents/ui/config.qml

https://invent.kde.org/plasma/plasma-workspace/commit/f2afc13d6b3adb439c0571695ecd1e68d63b6a5f