Bug 399281 - Changing a brush's name removes the tags of the brush
Summary: Changing a brush's name removes the tags of the brush
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tagging (other bugs)
Version First Reported In: 4.1.3
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Halla Rempt
URL:
Keywords:
: 420594 422907 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-10-01 15:08 UTC by acc4commissions
Modified: 2021-03-25 13:24 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description acc4commissions 2018-10-01 15:08:50 UTC
SUMMARY
tags seem to be removed after changing the brush's name. After re-adding the tag and rebooting krita, It creates a dummy brush icon has the original brush name.

STEPS TO REPRODUCE
1. make a custom brush and a tag.
2. add the tag to the brush.
3. change the name of the brush and check the tag. (It's gone)
4. re-add the tag and reboot krita
5. check the 'All' brush list.

SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 5.9.3

ADDITIONAL INFORMATION

After doing this to a brush, overwriting that specific brush starts to remove the tags of the brush. It still claims it has the tag if I overwrite, but it doesn't show up in the brush list under that tag. It's officially removed after rebooting krita.

Man this is a mess. XD
Comment 1 Emmet O'Neill 2018-10-06 17:32:46 UTC
Hi there. 

Following your reproduction steps #1-3, I'm able to confirm part of this issue, specifically that a brush's tags are not carried over when renamed.

However, I wasn't able to reproduce the part about Krita creating a "dummy brush icon with the original brush name". Could it be possible that you accidentally saved the brush original brush twice at some point? Is this something you have been able to reproduce more than once?

I'm going to confirm this bug, as renaming should carry tags over, though I think we'll need more information about how to reproduce the behavior described in steps 4 and 5.

As always, thanks for the report.
Comment 2 Emmet O'Neill 2018-10-06 17:35:13 UTC
I should also add that I tested on Linux @ master.
Comment 3 Tiar 2020-06-13 11:36:40 UTC
*** Bug 422907 has been marked as a duplicate of this bug. ***
Comment 4 Justin Zobel 2020-11-13 03:15:17 UTC
Removing Assigned tag as no activity in 2 years.
Comment 5 Halla Rempt 2020-11-13 08:36:17 UTC
Do not change the status of bugs, Justin.
Comment 6 Tiar 2020-12-15 00:56:53 UTC
*** Bug 420594 has been marked as a duplicate of this bug. ***
Comment 7 Halla Rempt 2021-03-25 13:24:11 UTC
This has been fixed in master. Tested with 60caab4673