Bug 399275 - Khelpcenter menu does not work (some parts of TreeView)
Summary: Khelpcenter menu does not work (some parts of TreeView)
Status: RESOLVED FIXED
Alias: None
Product: khelpcenter
Classification: Applications
Component: general (show other bugs)
Version: 5.7.3
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Documentation Editorial Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-01 12:39 UTC by Pavel
Modified: 2018-11-19 00:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
KInfoCenter Modules — Help Center (234.27 KB, image/jpeg)
2018-10-01 12:39 UTC, Pavel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel 2018-10-01 12:39:18 UTC
Created attachment 115343 [details]
KInfoCenter Modules — Help Center

Summary

Package: kde5-khelpcenter version 5.7.3 
KDE Frameworks Version 5.51.0
Qt Version 5.11.1

KDE Plasma Version 5.13.90
Kernel Version 4.15.0-34-generic
OS Type: 64-bit

NAME="KDE neon"
VERSION="Developer Edition"
ID=neon
ID_LIKE="ubuntu debian"
PRETTY_NAME="KDE neon Developer Edition"
VERSION_ID="18.04"
HOME_URL="http://neon.kde.org/"
SUPPORT_URL="http://neon.kde.org/"
BUG_REPORT_URL="http://bugs.kde.org/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

On 2018.09.26, an upgrade was made by command dist-upgrade. 
Incorrect to works the contents index tree on left half of application window (TreeWidget) khelpcenter.

STEPS TO REPRODUCE
0. Open «System Settings» (systemsettings5) → Input Devices → Mouse → General → Choose «Double-click to open files and folders» (!!!)
1. Start khelpcenter (in any way).
2. Choose menu item - "Kinfocenter Modules" -  in the left half of the application window.
3. Items not expand.

OBSERVED RESULT
1. Pressing the menu items does not result in any result (the corresponding help information is not displayed in the right half of the application window).
(Open khelpcenter → choose «KinfoCenter Modules» - items not expand )

EXPECTED RESULT
Menu should work correctly:
- all menu items should be displayed,
- subparagraphs should open and disclose subtrees,
- the corresponding help is displayed in the right half of the application window.
Comment 1 Luigi Toscano 2018-11-19 00:47:35 UTC
Git commit d2940a285b1b3657c51a45d85947dd0196249216 by Luigi Toscano, on behalf of Aleksei Nikiforov.
Committed on 19/11/2018 at 00:47.
Pushed by ltoscano into branch 'Applications/18.12'.

Contents items expanding issue

Summary:
There is contents tree on left side of application window of Khelpcenter.

If you select "Single click to open files and directories" in application "System Settings" in menu "Input devices" -> "Mouse", upon single click on any expandable item in contents (let's for example take "Application Manuals" or "System Settings Modules") it expands, upon double click it swiftly expands and collapses back. If it's already expanded, it collapses, and on double click it collapses and expands back.

However, if you select "Double click to open files and directories (select icons on first click)" in "System Settings", you no longer can expand/collapse any expandable items in Khelpcenter's contents tree using mouse clicks. You need to double click to expand it, and in best case you can see it swiftly expanding and collapsing back if it's collapsed, or vice versa if it's expanded.

It looks like with "Double click" setting selected contents item receives two events on double click: "selected" and "double click". On first event "expanded/collapsed" state is toggled via explicit calls to corresponding functions (see function Navigator::slotItemSelected), on second event this state is toggled again, thus reverting it to original state. This patch sets a specific setting to get rid of second event and make behaviour similar no matter which mouse settings is used, "single click" or "double click".

Reviewers: yurchor, mlaurent, ltoscano

Reviewed By: ltoscano

Subscribers: pavelmos, ltoscano, kde-doc-english

Tags: #documentation

Differential Revision: https://phabricator.kde.org/D16352

M  +1    -0    navigator.cpp

https://commits.kde.org/khelpcenter/d2940a285b1b3657c51a45d85947dd0196249216