Bug 399194 - No resize cursor for the corners of GTK CSD windows
Summary: No resize cursor for the corners of GTK CSD windows
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.13.5
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-28 19:43 UTC by Björn Feber
Modified: 2018-11-04 17:06 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.14.3


Attachments
How the bug looks like (1.58 KB, image/png)
2018-09-29 09:32 UTC, Björn Feber
Details
How it looks like when it is fixed (2.40 KB, image/png)
2018-09-29 09:33 UTC, Björn Feber
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Feber 2018-09-28 19:43:07 UTC
SUMMARY
When you hover over the corners of GTK CSD windows,
the cursor is the fallback Adwaita one.
This is because there are some missing symlinks
in the breeze cursor themes:
sw-resize --> size_bdiag
ne-resize --> size_bdiag
nw-resize --> size_fdiag
se-resize --> size_fdiag

STEPS TO REPRODUCE
1. Hover over the corners of a GTK CSD window

OBSERVED RESULT
The cursor changes into a fallback Adwaita one

EXPECTED RESULT
It should be a breeze cursor

SOFTWARE VERSIONS
KDE Plasma Version: 5.13.5
KDE Frameworks Version: 5.50.0
Qt Version: 5.11.2
Comment 1 Björn Feber 2018-09-29 09:32:58 UTC
Created attachment 115304 [details]
How the bug looks like
Comment 2 Björn Feber 2018-09-29 09:33:23 UTC
Created attachment 115305 [details]
How it looks like when it is fixed
Comment 3 Nicolas Fella 2018-10-03 12:15:33 UTC
Git commit baab8494bbe91f66121d4623db6b3349ccd986f0 by Nicolas Fella.
Committed on 03/10/2018 at 12:15.
Pushed by nicolasfella into branch 'master'.

[Cursors] link *-resize to *_corner cursor

Summary:
When hovering at the window corner in Nautilus an Adwaita curser is shown. Link it to the Breeze equivalent.

Test Plan:
Before:
{F6298098}

After:
{F6298099}

Reviewers: #breeze, hpereiradacosta, ngraham, andreask

Reviewed By: #breeze, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15889

A  +1    -0    cursors/Breeze/Breeze/cursors/ne-resize
A  +1    -0    cursors/Breeze/Breeze/cursors/nw-resize
A  +1    -0    cursors/Breeze/Breeze/cursors/se-resize
A  +1    -0    cursors/Breeze/Breeze/cursors/sw-resize

https://commits.kde.org/breeze/baab8494bbe91f66121d4623db6b3349ccd986f0
Comment 4 Björn Feber 2018-10-03 16:28:46 UTC
There is still an issue! The cursors got linked with the *_corner cursors,
but this is wrong, since those are different cursor than the normal resize cursors! This is how the links should be:
sw-resize --> size_bdiag
ne-resize --> size_bdiag
nw-resize --> size_fdiag
se-resize --> size_fdiag
Comment 5 Nate Graham 2018-10-04 19:10:07 UTC
Fixed for-realzies with https://phabricator.kde.org/D15950
Comment 6 Nate Graham 2018-11-04 17:06:23 UTC
Git commit 0383cd9adc75c3149b4bd0799dd98b44b6244040 by Nate Graham, on behalf of Nicolas Fella.
Committed on 04/11/2018 at 17:04.
Pushed by ngraham into branch 'Plasma/5.14'.

[Cursors] link *-resize to *_corner cursor

Summary:
When hovering at the window corner in Nautilus an Adwaita curser is shown. Link it to the Breeze equivalent.

Test Plan:
Before:
{F6298098}

After:
{F6298099}

Reviewers: #breeze, hpereiradacosta, ngraham, andreask

Reviewed By: #breeze, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15889

A  +1    -0    cursors/Breeze/Breeze/cursors/ne-resize
A  +1    -0    cursors/Breeze/Breeze/cursors/nw-resize
A  +1    -0    cursors/Breeze/Breeze/cursors/se-resize
A  +1    -0    cursors/Breeze/Breeze/cursors/sw-resize

https://commits.kde.org/breeze/0383cd9adc75c3149b4bd0799dd98b44b6244040