SUMMARY The konsole profile widget is only controllable with the mouse. Selecting a profile by keyboard does not work. STEPS TO REPRODUCE 1. Create some profiles in konsole so you can see them in the konsole profiles widget 2. Open the konsole profiles widget. Either by clicking on its icon or in this case more logical via a hotkey that is assigned to it. 3. Try to chose a profile with cursor up and down and to select on with the enter key OBSERVED RESULT Cursor up/down and enter does not work. They have no effect. EXPECTED RESULT You should be able to choose and select a profile from the widget by keyboard. SOFTWARE VERSIONS KDE Plasma Version: 5.12.7 KDE Frameworks Version: 5.47.0 Qt Version: 5.9.5 ADDITIONAL INFORMATION This feature was added some years ago to kde4. But with kde5 (plasma) it was lost again.
Git commit 943122b4429de6ceb113fb7b3ede6c2b4036965d by Thomas Surrel. Committed on 05/10/2018 at 09:23. Pushed by thsurrel into branch 'master'. [KonsoleProfiles applet] Fix navigating with the keyboard Summary: BUG: 399192 Test Plan: Create several profiles in Konsole. Open the Konsole Profiles applet, using the keyboard arrows should now move the selected item. Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D15877 M +2 -3 applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml https://commits.kde.org/kdeplasma-addons/943122b4429de6ceb113fb7b3ede6c2b4036965d
Thank you for working on this issue so quickly. I can't await to test this small fix in real life. (I hope it makes its way soon to a backported version for kubuntu 18.04. Well, if not, I have a reason to update to the forthcoming 18.10.)
Thomas, if it applies cleanly, we might consider cherry-picking the fix onto the Plasma/5.12 branch and then merging that onto the Plasma 5.14 branch. Otherwise, this will only be available in Plasma 5.15. With your fancy new Contributor account, you can now do all of this! Let me know if you need a hand.
Yes, I could use some guidance here. The https://community.kde.org/Infrastructure/Phabricator#Workflow talks about how to rebase on a stable branch, but since it has already been landed on master I would like to be sure I do the cherry-picking correctly. Arc is quite new to me. Thanks in advance, Nate!
Another patch is needed to get this bug fully resolved, btw: https://phabricator.kde.org/D15963
We don't use `arc` for any of this part; it's just pure git tooling. Here's the process: 1. Find the hash of the commit. It's 943122b4429de6ceb113fb7b3ede6c2b4036965d for this one. 2. Check out the oldest stable branch, which is for 5.12: `git checkout plasma/5.12` 3. Cherry-pick the commit onto that branch: `git cherry-pick 943122b4429de6ceb113fb7b3ede6c2b4036965d` 4. Push that change to the remote repo: `git push` 5. Now that the commit is on the oldest stable branch (plasma/5.12), merge it onto the next-newest stable branch, which is plasma/5.14: - `git checkout plasma/5.14` - `git merge plasma/5.12` - `git push` 6. Ordinarily, at this point you would merge the newest stable branch to master, but this time there's no need since you landed the commit on master so it's already there. Let me know if you need a hand with anything! This is the typical merge-to-master workflow that we follow with all commits to stable branches. In the future, if you land your patch on the stable branch (because it's a bugfix and doesn't change any strings), you'll always do this, and won't have to cherry-pick it onto the stable branch first.
Git commit 91ee9cc72a490ccaf931c49229a9b8d2303b8e65 by Thomas Surrel. Committed on 08/10/2018 at 07:19. Pushed by thsurrel into branch 'Plasma/5.12'. [KonsoleProfiles applet] Fix navigating with the keyboard Summary: BUG: 399192 Test Plan: Create several profiles in Konsole. Open the Konsole Profiles applet, using the keyboard arrows should now move the selected item. Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D15877 M +2 -3 applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml https://commits.kde.org/kdeplasma-addons/91ee9cc72a490ccaf931c49229a9b8d2303b8e65
Thank you very much for the detailed explanation. Pure git is more familiar to me than arc ! Do you know who could have a look at https://phabricator.kde.org/D15963 ? I'd like to push that as well to close this bug completely.
I've pinged Eike Hein about that.