Bug 399153 - Selecting a picture with a tag and another without that tag, the checkbox is black instead of gray.
Summary: Selecting a picture with a tag and another without that tag, the checkbox is ...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Manager (other bugs)
Version First Reported In: 6.0.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-27 17:59 UTC by MarcP
Modified: 2018-09-28 22:00 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.0.0
Sentry Crash Report:


Attachments
Screen capture showing this behavior (703.01 KB, image/gif)
2018-09-27 17:59 UTC, MarcP
Details

Note You need to log in before you can comment on or make changes to this bug.
Description MarcP 2018-09-27 17:59:27 UTC
Created attachment 115269 [details]
Screen capture showing this behavior

SUMMARY

When you select a picture with a tag, and another one without that tag, in the Captions/Tags panel in the right they appear as a checked checkbox (as if all selected pictures already had that tag). It should appear in gray, indicating that not all elements have that tag. See attached screen capture.

I think it only happens in some cases, because gray checkboxes often appear when selecting pictures with different tags. Maybe it only happens with pictures with no tags at all.

STEPS TO REPRODUCE
1. Select a picture with a tag.
2. Select another picture without any tags.
3. Check the Tags in the Captions panel.

OBSERVED RESULT
Tag appears checked (black).

EXPECTED RESULT
Tags should appear as a gray square.

SOFTWARE VERSIONS
digiKam-6.0.0-beta1-20180920T204303-Win64.exe in Windows 10 64 bit
Comment 1 Maik Qualmann 2018-09-27 20:12:03 UTC
You mean partially checked with gray CheckBox. Untagged images are ignored and I think that's right. It may look flawed with 2 images, but if you mark a lot of images with different tags. If there would be a picture with no tags, all would have to be displayed as partially checked. It can not be that either.

Maik
Comment 2 MarcP 2018-09-27 20:16:13 UTC
Ah, ok, it's on purpose.

I don't know, I feel that even if all but one picture had a tag, the checkbox should be partially checked. Why make a distinction between pictures without tags, and pictures that already contain some tags?

Anyway, it's not a big deal.
Comment 3 Maik Qualmann 2018-09-28 22:00:40 UTC
Git commit a6db63a3bf8eec1c96a801808b170f5c7f775ccf by Maik Qualmann.
Committed on 28/09/2018 at 21:59.
Pushed by mqualmann into branch 'master'.

use images without tags also as partially checked
FIXED-IN: 6.0.0

M  +2    -2    NEWS
M  +27   -6    core/libs/imageproperties/disjointmetadata.cpp

https://commits.kde.org/digikam/a6db63a3bf8eec1c96a801808b170f5c7f775ccf