Bug 399145 - Masks can be added to locked layer
Summary: Masks can be added to locked layer
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: 4.1.1
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Eoin O'Neill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-27 13:43 UTC by katearcher89
Modified: 2018-10-11 08:23 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description katearcher89 2018-09-27 13:43:54 UTC
Masks can be added to a locked layer and that's kinda wrong.

How to reproduce:
1. Create a layer.
2. Lock it.
3. Add a mask onto it(any mask will do: transform/transparency/filter layer)
3.1 In some cases(i.e. filter layers) you can adjust the layer upon the creation.
4. Get a mask on a locked layer that cannot be edited as well since the parent is locked.

Expected: Being unable to add a mask to a locked layer at all.
Comment 1 Eoin O'Neill 2018-10-10 09:56:09 UTC
Git commit 8e19e4649445e6633a29e5586d923ede5cb0d4a4 by Eoin O'Neill.
Committed on 10/10/2018 at 09:53.
Pushed by eoinoneill into branch 'master'.

Masks Can No Longer Be Added to Locked Layers

This corrects unexpected behavior of being able to add masks to a locked layer even though
you could not edit the masks immediately after. Now, trying to add a mask to a locked layer
will not work.

M  +20   -0    libs/ui/kis_mask_manager.cc

https://commits.kde.org/krita/8e19e4649445e6633a29e5586d923ede5cb0d4a4
Comment 2 Halla Rempt 2018-10-11 08:23:19 UTC
Git commit b16e6d89522d5c1610301127f3f15106ef5cb425 by Boudewijn Rempt, on behalf of Eoin O'Neill.
Committed on 11/10/2018 at 07:53.
Pushed by rempt into branch 'krita/4.1'.

Masks Can No Longer Be Added to Locked Layers

This corrects unexpected behavior of being able to add masks to a locked layer even though
you could not edit the masks immediately after. Now, trying to add a mask to a locked layer
will not work.

(cherry picked from commit 8e19e4649445e6633a29e5586d923ede5cb0d4a4)

M  +20   -0    libs/ui/kis_mask_manager.cc

https://commits.kde.org/krita/b16e6d89522d5c1610301127f3f15106ef5cb425