Bug 399129 - Track disable does not work as expected.
Summary: Track disable does not work as expected.
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-27 07:22 UTC by Evert Vorster
Modified: 2018-09-28 12:59 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Evert Vorster 2018-09-27 07:22:32 UTC
SUMMARY

On 2018-09-27 of kdenlive timeline refactoring branch, compiled from git.
When disabling tracks the wrong icon is toggled, and sometimes no icon is toggled. 


STEPS TO REPRODUCE
1. generate new project with 7 tracks. (4 video and 3 audio )
2. Try to disable a audio track. 

OBSERVED RESULT
Audio track is sometimes disabled, sometimes not, but more importantly, when the track is disabled on of the video tracks icon is toggled into the disabled icon, although the track is not disabled. 

EXPECTED RESULT
The track icon to be toggled, and the track to be disabled. 

SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
This seem to be affecting the lock icons as well. 

Not knowing much about coding this feels like something is inverted in the track numbering, and an old module speaking to a new module is getting the numbering wrong.
Comment 1 Jean-Baptiste Mardelle 2018-09-28 12:59:21 UTC
Git commit b4fb1a824222b9d7cd6bb2bc51731170bd9e9a6a by Jean-Baptiste Mardelle.
Committed on 28/09/2018 at 12:58.
Pushed by mardelle into branch 'refactoring_timeline'.

Fix track index corruption

M  +2    -2    src/timeline2/model/timelineitemmodel.cpp
M  +2    -2    src/timeline2/model/trackmodel.cpp
M  +5    -5    src/timeline2/view/timelinewidget.cpp
M  +2    -0    src/timeline2/view/timelinewidget.h

https://commits.kde.org/kdenlive/b4fb1a824222b9d7cd6bb2bc51731170bd9e9a6a