Bug 399103 - New layers made with group layer selected is created inside this
Summary: New layers made with group layer selected is created inside this
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 399152 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-09-26 12:27 UTC by David
Modified: 2018-12-25 08:20 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David 2018-09-26 12:27:48 UTC
A new created layer is placed on top of the currently selected one in the layer stack.
When the selected one is a group layer the new layer is instead created inside this group.

For consistency I would like to have the layer created above this as well, besides the group at the same level, not inside it.
Especially so if the group is collapsed.

Krita 4.2.0 testing from Lime PPA.
Comment 1 Halla Rempt 2018-09-26 12:41:36 UTC
This has been discussed before: https://phabricator.kde.org/D15523 . In the end, we concluded that we would not implement it like this, both because it would in our opinion not improve workflow, and because the way it works right now is consistent with other applications, so wouldn't surprise new users.
Comment 2 David 2018-09-26 13:02:27 UTC
I see your point and why you choose to keep the current behaviour.
In my own workflow I far more often want to create a layer above the group rather than in it.

How about adding a modifier? Alt+new layer creates it above rather than inside a group?
Comment 3 Halla Rempt 2018-09-26 13:33:49 UTC
Well, maybe. Finding a good modifier is going to be tricky, though.
Comment 4 Halla Rempt 2018-09-27 17:51:09 UTC
*** Bug 399152 has been marked as a duplicate of this bug. ***
Comment 5 wkg28406 2018-09-27 19:03:53 UTC
Opinion:

Current workflow is acceptable.

Except:
If the group is collapsed, do not insert inside the group, instead insert above.

Only insert above if collapsed.
Comment 6 katearcher89 2018-09-28 00:39:59 UTC
(In reply to bugs from comment #5)
> Opinion:
> 
> Current workflow is acceptable.
> 
> Except:
> If the group is collapsed, do not insert inside the group, instead insert
> above.
> 
> Only insert above if collapsed.


I kinda like that approach, by this double behaviour we are separating actions visually while making them more consistent: a collapsed group is basically a layer, since an opened group is an indication that the user is working with that group right now and the chances are he is wanting to put a newly created layer in that group.
Comment 7 Halla Rempt 2018-09-28 08:59:36 UTC
I've added the suggestion to the phabricator diff that razvan is working on.
Comment 8 mvowada 2018-12-17 12:53:48 UTC
(In reply to bugs from comment #5)
> If the group is collapsed, do not insert inside the group, instead insert
> above.
> 
> Only insert above if collapsed.

Hi. I would agree with comment #5: 
- if the group is collapsed then create the new layer out of it and above it.
Comment 9 Dmitry Kazakov 2018-12-25 08:20:29 UTC
Git commit 5f819ec9830f83e820e78a84a162580da1506c60 by Dmitry Kazakov.
Committed on 25/12/2018 at 08:18.
Pushed by dkazakov into branch 'master'.

Insert new layer above selected group layer

Summary: About a month ago or something I said in the irc channel that
I'd t ake a look at inserting the new layers above the group layer if th
e group layer is selected as opposed to inserting it in the group. The
rationale is that you can already easily insert the layer in the group
by selecting any layer inside that group, but if you want to insert the
layer just above the group you're forced to do it in two steps: first
insert the layer inside the group, then move the layer above the
group (eg. with ctrl+pgup).  It's not a big deal, but I know at least
one person that mentioned this before (don't remember if it was in irc
or opened a bug).

In any case it's a very tiny change that I finally got around to doing it.

The patch by Razvan Radulescu (https://phabricator.kde.org/p/razvanr/)
Reviewers: rempt, scottpetrovic, #krita
Reviewed By: rempt, #krita
Tags: #krita
Differential Revision: https://phabricator.kde.org/D15523

M  +6    -0    libs/ui/kis_layer_manager.cc

https://commits.kde.org/krita/5f819ec9830f83e820e78a84a162580da1506c60