Bug 398864 - Weird behavior of icons
Summary: Weird behavior of icons
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 5.12.6
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-20 09:51 UTC by Oleg Solovyov
Modified: 2018-11-15 22:35 UTC (History)
4 users (show)

See Also:
Latest Commit: https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.12&id=7e4a522cec25cf4945645d8379e8145226cc85b8
Version Fixed In: 5.12.8

Attachments
Clean desktop (423.47 KB, image/png)
2018-09-20 09:51 UTC, Oleg Solovyov 		Details
Created a folder somewhere under trash icon (429.70 KB, image/png)
2018-09-20 09:51 UTC, Oleg Solovyov 		Details
Selected all icons (438.03 KB, image/png)
2018-09-20 09:53 UTC, Oleg Solovyov 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Solovyov 2018-09-20 09:51:14 UTC 
Created attachment 115114 [details]
Clean desktop

I created a folder and there is something weird happened.

How to reproduce:
1) remove ~/.config (or rename it)
2) log in
3) create a folder

FIXED in 5.13 branch, NOT FIXED in 5.12
Comment 1 Oleg Solovyov 2018-09-20 09:51:58 UTC 
Created attachment 115115 [details]
Created a folder somewhere under trash icon

Trash icon just duplicated
Comment 2 Oleg Solovyov 2018-09-20 09:53:56 UTC 
Created attachment 115116 [details]
Selected all icons

There are two trashes on the desktop, there is an inactive one (you can't do anything with it, even select it)
Comment 3 Nate Graham 2018-09-20 19:30:39 UTC 
> FIXED in 5.13 branch, NOT FIXED in 5.12

This never should have gotten into a release. It was introduced by https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.12&id=1cb71a2cca8a46512f5ac0cb03da268dde8d9c7d, and reverted with https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.12&id=f23b9dc0d57df80863e988208e60135a7f42ad12 -- both of which were never released.

I cannot reproduce the issue in Kubuntu with 5.12.6. Can you confirm and be absolutely sure that you are using Plasma 5.12.6? And in what distro?
Comment 4 Oleg Solovyov 2018-09-27 07:15:27 UTC 
(In reply to Nate Graham from comment #3)
> > FIXED in 5.13 branch, NOT FIXED in 5.12
> 
> This never should have gotten into a release. It was introduced by
> https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.
> 12&id=1cb71a2cca8a46512f5ac0cb03da268dde8d9c7d, and reverted with
> https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.
> 12&id=f23b9dc0d57df80863e988208e60135a7f42ad12 -- both of which were never
> released.
> 
> I cannot reproduce the issue in Kubuntu with 5.12.6. Can you confirm and be
> absolutely sure that you are using Plasma 5.12.6? And in what distro?

ALT Workstation K, I am *really* sure that I am using 5.12.6
Comment 5 Oleg Solovyov 2018-09-27 09:14:14 UTC 
UPDATE: I was confused upon testing earlier.

Bug is not fixed in v5.13.5 and v5.12.7

as far as I remember, the problem appears after commit 4c977747bd9069630c4e0eb68cd8a45176291880
Comment 6 Oleg Solovyov 2018-09-27 13:14:36 UTC 
It's *really* weird - I have Plasma 5.12.6 and can reproduce the bug, which seems to be broken some commits after that release
Comment 7 Nate Graham 2018-09-27 13:22:47 UTC 
Eike, any ideas?
Comment 8 Oleg Solovyov 2018-10-01 12:25:55 UTC 
I think, there are two different bugs were fixed separately from each other.
1) "Phantom" icons (on third screenshot we have 5 icons and 4 selected but we have only 4 items on desktop)
2) "Moving" icons (notice that after creating folder first icon were moved to the right by two units)

commit 11bd2df1 is good at both
e647b47b is broken (phantom icons appears)
62116353 is broken (both phantom and moving icons)
Comment 9 Oleg Solovyov 2018-10-01 15:59:14 UTC 
(In reply to Nate Graham from comment #3)
> > FIXED in 5.13 branch, NOT FIXED in 5.12
> 
> This never should have gotten into a release. It was introduced by
> https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.
> 12&id=1cb71a2cca8a46512f5ac0cb03da268dde8d9c7d, and reverted with
> https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.
> 12&id=f23b9dc0d57df80863e988208e60135a7f42ad12 -- both of which were never
> released.
> 
> I cannot reproduce the issue in Kubuntu with 5.12.6. Can you confirm and be
> absolutely sure that you are using Plasma 5.12.6? And in what distro?

Just found out that it's something different from that commits.
f23b9dc0d57df80863e988208e60135a7f42ad12^ is clean
Comment 10 Oleg Solovyov 2018-10-02 11:19:38 UTC 
Found!

commit e03217edfc1a002a3ea654c58a28c1e1f689f3bf fixes both.
It was not backported into 5.13 and 5.12 branches.
Comment 11 Kai Uwe Broulik 2018-10-02 13:04:25 UTC 
Could probably be easily cherry-picked to 5.12? Eike?
Comment 12 Eike Hein 2018-10-04 11:10:31 UTC 
^ Please do, thx
Comment 13 Kai Uwe Broulik 2018-10-04 11:12:51 UTC 
Will do
Comment 14 Oleg Solovyov 2018-10-08 08:17:59 UTC 
ping?
Comment 15 Eike Hein 2018-10-08 09:46:24 UTC 
Afaik Kai backported it soon after
Comment 16 Nate Graham 2018-10-08 20:15:29 UTC 
So is this done yet? Kai?
Comment 17 Kai Uwe Broulik 2018-10-08 20:22:31 UTC 
Yup, is backported to 5.12 (there is no more 5.13 release) https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.12&id=7e4a522cec25cf4945645d8379e8145226cc85b8
Comment 18 Nate Graham 2018-11-15 22:35:54 UTC 
*** Bug 401023 has been marked as a duplicate of this bug. ***