Bug 398811 - Settings window should never let the categories list get a vertical scrollbar
Summary: Settings window should never let the categories list get a vertical scrollbar
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 23.04.1
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-18 17:21 UTC by Patrick Silva
Modified: 2023-11-18 17:45 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
demonstration (99.21 KB, video/webm)
2018-09-18 17:21 UTC, Patrick Silva
Details
newaita icon theme (69.63 KB, image/png)
2020-05-18 15:29 UTC, Patrick Silva
Details
papirus icon theme (68.42 KB, image/png)
2020-05-18 15:30 UTC, Patrick Silva
Details
papirus + liberation sans (77.10 KB, image/png)
2020-05-26 22:34 UTC, Patrick Silva
Details
papirus + default Noto Sans (78.89 KB, image/png)
2020-05-26 22:35 UTC, Patrick Silva
Details
breeze-icons with 10pt noto sans (79.53 KB, image/png)
2020-05-26 22:49 UTC, Noah Davis
Details
Krunner kcm + papirus (137.81 KB, image/png)
2020-05-27 13:05 UTC, Patrick Silva
Details
Krunner kcm + breeze (157.19 KB, image/png)
2020-05-27 13:05 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-09-18 17:21:14 UTC
Created attachment 115081 [details]
demonstration

For some reason icons on the left side become bigger when I set a custom icon theme and consequently a vertical scroll bar appears. Watch the screencast recorded on neon dev unstable please.
Reproducible with the following Icon themes, all installed from KDE store:
papirus
newaita
flat remix light
Comment 1 Nate Graham 2018-09-18 19:39:59 UTC
Looks like the icons in the 3rd-party theme are bigger. Probably too big, really.

Maybe what we should do is keep the category list on the left from ever having a scrollbar and make the window taller if they would have one.
Comment 2 Patrick Silva 2019-03-02 15:36:56 UTC
The scroll bar is no longer present on Arch Linux.
However this issue is still valid on neon dev unstable.

Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.56.0
Qt Version: 5.12.0
Comment 3 Patrick Silva 2019-08-06 19:49:03 UTC
it's still happening on Arch Linux with Dolphin 19.08 RC and newaita icon theme at least.
Comment 4 Patrick Silva 2020-01-17 17:28:47 UTC
cannot reproduce with dolphin 19.12.1.

Operating System: Arch Linux 
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0
Comment 5 Patrick Silva 2020-05-16 21:35:41 UTC
oh no, it's reproducible again with Dolphin 20.04.1 and newaita or papirus icon themes.

Operating System: Arch Linux 
KDE Plasma Version: 5.18.90
KDE Frameworks Version: 5.70.0
Qt Version: 5.15.0 rc2
Comment 6 Nate Graham 2020-05-18 14:37:13 UTC
Please attach a screenshot.
Comment 7 Patrick Silva 2020-05-18 15:29:43 UTC
Created attachment 128575 [details]
newaita icon theme
Comment 8 Patrick Silva 2020-05-18 15:30:08 UTC
Created attachment 128576 [details]
papirus icon theme
Comment 9 Nate Graham 2020-05-18 15:57:03 UTC
Those icons look too large--larger than the equivalent breeze icons. Feels like a problem with the icon themes.

Thoughts, Noah?
Comment 10 Christoph Feck 2020-05-18 16:23:21 UTC
The icon size for Dialog icons is (was?) configurable.
Comment 11 Nate Graham 2020-05-18 16:25:51 UTC
I don't think that's the problem here.
Comment 12 Noah Davis 2020-05-18 17:21:10 UTC
(In reply to Nate Graham from comment #9)
> Those icons look too large--larger than the equivalent breeze icons. Feels
> like a problem with the icon themes.
> 
> Thoughts, Noah?

Qt applications have full control over the sizes of icons and will shrink down icons that are larger than the specified size, AFAIK. By default, the size should be 32px here and it is 32px on my machine. Perhaps the user found a way to set the size too high?
Comment 13 Patrick Silva 2020-05-24 20:56:46 UTC
I have never changed any icons size setting on my system.
I have already found the culprit: my font settings.
This bug occurs on Arch and neon unstable when I use lebaration sans font
with papirus or newaita icon themes.
No scroll bar when any of the mentioned icon themes is used with default font settings.
Comment 14 Patrick Silva 2020-05-26 22:34:03 UTC
Created attachment 128818 [details]
papirus + liberation sans
Comment 15 Patrick Silva 2020-05-26 22:35:05 UTC
Created attachment 128819 [details]
papirus + default Noto Sans
Comment 16 Noah Davis 2020-05-26 22:48:41 UTC
(In reply to Patrick Silva from comment #15)
> Created attachment 128819 [details]
> papirus + default Noto Sans

Those icons are larger than they normally are.
Comment 17 Noah Davis 2020-05-26 22:49:49 UTC
Created attachment 128821 [details]
breeze-icons with 10pt noto sans
Comment 18 Patrick Silva 2020-05-26 23:38:50 UTC
Is there a bug with the icon themes then?
I have just found another icon theme that creates the scroll bar: Qogir.
Comment 19 Noah Davis 2020-05-26 23:59:08 UTC
(In reply to Patrick Silva from comment #18)
> Is there a bug with the icon themes then?
> I have just found another icon theme that creates the scroll bar: Qogir.

I have no idea. Icon themes shouldn't be causing any problems. The application should scale icons up or down as it needs to.
Comment 20 Patrick Silva 2020-05-27 13:05:27 UTC
Created attachment 128838 [details]
Krunner kcm + papirus

humm, Krunner kcm also has bigger icons with third party icon theme.
Comment 21 Patrick Silva 2020-05-27 13:05:56 UTC
Created attachment 128839 [details]
Krunner kcm + breeze
Comment 22 Patrick Silva 2021-09-20 13:06:02 UTC
it's still reproducible on neon unstable with qogir and papirus icon themes.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.23.80
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.3
Graphics Platform: Wayland
Comment 23 Patrick Silva 2023-11-18 17:45:45 UTC
Cannot reproduce.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.81.0
KDE Frameworks Version: 5.245.0
Qt Version: 6.6.0
Graphics Platform: X11