Bug 398809 - "unsafe characters" in the URL of a bookmark end up encoded in the invoked URL
Summary: "unsafe characters" in the URL of a bookmark end up encoded in the invoked URL
Status: RESOLVED WORKSFORME
Alias: None
Product: krunner
Classification: Plasma
Component: bookmarks (other bugs)
Version First Reported In: 5.13.5
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-18 16:10 UTC by Friedrich W. H. Kossebau
Modified: 2021-01-01 04:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Friedrich W. H. Kossebau 2018-09-18 16:10:49 UTC
Given Firefox with a bookmark for a URL which uses "unsafe" characters (term found on quick search, not sure if correct one), e.g. "|".
When invoking the bookmark by krunner (via a match of the bookmark description), the URL seems to be sent to Firefox completely encoded, i.e. also those unsafe characters being encoded.
E.g. "index.php?object=tx|37" becomes "index.php?object=tx%257C37".

Which seems to fail with the web server which expects those "unsafe" characters in the URLs and does not try to decode anything.

No public URL known sadly, to be an example here.

Looking at the bookmarks krunner code, it seems the raw URL string is taken from the Firefox bookmark database and then fed into a QUrl (with QUrl::TolerantMode) and then passed to QDesktopServices:
```
QUrl url = QUrl(term);
QDesktopServices::openUrl(url);
```
https://cgit.kde.org/plasma-workspace.git/tree/runners/bookmarks/bookmarksrunner.cpp#n111

Had no chance yet to add some debug output/inspection to find where the (wrong) encoding is actually applied.
Comment 1 Justin Zobel 2020-12-02 04:04:46 UTC
As it has been a while since this was reported, can you please test and confirm if this issue is still occurring or if this bug report can be marked as resolved.

I have set the bug status to "needsinfo" pending your response, please change back to "reported" or "resolved" when you respond, thank you.
Comment 2 Bug Janitor Service 2020-12-17 04:34:17 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Bug Janitor Service 2021-01-01 04:39:39 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!