Bug 398718 - User should be able to start typing to search after pressing Ctrl+F
Summary: User should be able to start typing to search after pressing Ctrl+F
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 0.3.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-16 13:37 UTC by Matej Mrenica
Modified: 2018-10-04 05:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2018-09-16 13:37:58 UTC
...but instead one needs to click into the search bar.
Comment 1 Matthieu Gallien 2018-09-16 13:42:17 UTC
I will fix it.
Comment 2 Matej Mrenica 2018-09-16 18:02:25 UTC
(In reply to Matthieu Gallien from comment #1)
> I will fix it.

Thanks, in addition to this, could we also skip the need to use Ctrl+F, or is that too much?
Comment 3 Matthieu Gallien 2018-09-16 18:30:43 UTC
(In reply to mthw0 from comment #2)
> (In reply to Matthieu Gallien from comment #1)
> > I will fix it.
> 
> Thanks, in addition to this, could we also skip the need to use Ctrl+F, or
> is that too much?

What do you mean exactly ?

Is it that one could start typing as soon as the grid view is focused ?
Comment 4 Matej Mrenica 2018-09-16 19:05:10 UTC
Yes, exactly.
Comment 5 Matthieu Gallien 2018-09-19 20:14:25 UTC
I have posted a review that covers the need to have focus in the test entry control when pressing the shortcut to show the search bar.

https://phabricator.kde.org/D15607
Comment 6 Matej Mrenica 2018-09-20 11:49:19 UTC
Could this still make it into Elisa 0.3.0?
Comment 7 Matthieu Gallien 2018-09-20 12:02:25 UTC
(In reply to mthw0 from comment #6)
> Could this still make it into Elisa 0.3.0?

Yes this is the intended target.
Comment 8 Matthieu Gallien 2018-09-23 19:55:29 UTC
Git commit 3f15d516b98003e4a70ba2af368f8fa834104f07 by Matthieu Gallien.
Committed on 23/09/2018 at 19:55.
Pushed by mgallien into branch '0.3'.

Gives immediate focus to the search entry control after pressing the shortcut to show it

Summary:
when showing the filter panel, give it focus immediately

clean up the logic behind the filter bar expanded and collapsed states

Test Plan: pressing the shortcut gives focus

Reviewers: astippich, januz, ognarb

Reviewed By: astippich

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D15607

M  +16   -20   autotests/qmltests/tst_NavigationActionBar.qml
M  +0    -66   src/qml/ContentView.qml
M  +0    -13   src/qml/ElisaMainWindow.qml
M  +0    -3    src/qml/FileBrowserView.qml
M  +0    -3    src/qml/GridBrowserView.qml
M  +0    -3    src/qml/ListBrowserView.qml
M  +11   -3    src/qml/NavigationActionBar.qml

https://commits.kde.org/elisa/3f15d516b98003e4a70ba2af368f8fa834104f07
Comment 9 Matej Mrenica 2018-10-04 05:21:12 UTC
Version 0.3.0 provides the fix so I am closing this.