Bug 398688 - Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
Summary: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-16 00:44 UTC by auronhines
Modified: 2018-09-20 22:12 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/krita/127857b20cfdf5bee58599cf8a0bef74d6510fd0
Version Fixed In:
Sentry Crash Report:

Attachments
Info (42.98 KB, image/png)
2018-09-16 00:44 UTC, auronhines 		Details
patch, (4.60 KB, patch)
2018-09-18 14:47 UTC, auronhines 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description auronhines 2018-09-16 00:44:32 UTC 
Created attachment 114986 [details]
Info

Dir: /source/master/kundo2_aware_xgettext.sh

Lines: 39, 83, 84, 85
Comment 1 Halla Rempt 2018-09-16 08:09:13 UTC 
If you'd provide a patch, I'd apply it, but it is not a bug in Krita.
Comment 2 auronhines 2018-09-18 14:47:03 UTC 
Created attachment 115078 [details]
patch,

Here's the patch, If it breaks it let me know.
Comment 3 Halla Rempt 2018-09-18 14:59:12 UTC 
Git commit 127857b20cfdf5bee58599cf8a0bef74d6510fd0 by Boudewijn Rempt.
Committed on 18/09/2018 at 14:58.
Pushed by rempt into branch 'master'.

Remove places where cat doesn't need to be used

M  +4    -4    kundo2_aware_xgettext.sh

https://commits.kde.org/krita/127857b20cfdf5bee58599cf8a0bef74d6510fd0
Comment 4 auronhines 2018-09-18 20:50:06 UTC 
Where can i add these in the future?
Comment 5 Halla Rempt 2018-09-19 07:11:28 UTC 
Patches (but please use git diff to create a patch, instead of attaching the complete file) can go on phabricator.kde.org
Comment 6 Albert Astals Cid 2018-09-19 22:05:35 UTC 
It broke.

scripty is unhappy 

 extragear-graphics_krita /home/scripty/prod/trunk/l10n-kf5/templates/messages/extragear-graphics
kundo2_aware_xgettext.sh: line 39: file: No such file or directory
Comment 7 auronhines 2018-09-19 23:51:20 UTC 
let me see what died
Comment 8 auronhines 2018-09-19 23:56:26 UTC 
Ah I didn't add > to the end of cat.
Comment 9 auronhines 2018-09-20 00:04:44 UTC 
Albert, did it ever work and is the file being pointed at right? Even correcting some spelling still has it broken
Comment 10 auronhines 2018-09-20 00:12:46 UTC 
(So i forgot to do cat > sorry)
Comment 11 auronhines 2018-09-20 01:35:21 UTC 
Oh god... I'm using Cat not cmd WHYYY
Comment 12 Halla Rempt 2018-09-20 08:41:18 UTC 
Rigth, I'll just revert this --  "useless cat" isn't important. I only know it as an ancient comp.os.unix usenet meme...
Comment 13 auronhines 2018-09-20 17:21:12 UTC 
I don't think i'm to blame actually. After the revert the error still shows on Travis-cl

/home/travis/.travis/job_stages: line 98: ./configure: No such file or directory
Comment 14 auronhines 2018-09-20 18:06:51 UTC 
And I don't have a git cmd I can use but I need a diff to create a diff using phabricator
Comment 15 Albert Astals Cid 2018-09-20 18:40:29 UTC 
What does travis have to do with this?
Comment 16 auronhines 2018-09-20 19:00:24 UTC 
I used it to test the build and can you answer my question please? IDK how to.
Comment 17 Albert Astals Cid 2018-09-20 19:37:56 UTC 
I am not sure I understand your question.

Are you asking for git diff? or arc diff?
Comment 18 auronhines 2018-09-20 22:12:13 UTC 
git diff