Bug 398681 - Widget paddings/margins wrong
Summary: Widget paddings/margins wrong
Status: RESOLVED FIXED
Alias: None
Product: print-manager
Classification: Frameworks and Libraries
Component: applet (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2018-09-15 18:06 UTC by Sefa Eyeoglu
Modified: 2020-03-16 14:18 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.04.0
Sentry Crash Report:


Attachments
Screenshot of the widget (148.39 KB, image/png)
2018-09-15 18:06 UTC, Sefa Eyeoglu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sefa Eyeoglu 2018-09-15 18:06:24 UTC
Created attachment 114981 [details]
Screenshot of the widget

The items in the print-manager widget (in the systray) have weird paddings/margins. The icons and text are not centered in the list-item.
Comment 1 Nate Graham 2020-03-11 19:27:35 UTC
Submitted a patch to fix this: https://phabricator.kde.org/D27995
Comment 2 Nate Graham 2020-03-12 18:55:34 UTC
Git commit faea0b125911820c2c574cf17457f2d15c6100ba by Nate Graham.
Committed on 12/03/2020 at 18:55.
Pushed by ngraham into branch 'master'.

[Applet] Fix list item margins

Summary:
Related: bug 360199
FIXED-IN: 20.04.0

This is a minimal change needed to fix the aforementioned bugs. Ultimately I would like to
make a re-usable component to implement this "expandable list item" paradigm (which is
also used in the Networks, Bluetooth, Vaults, and Device Notifier applets) so we don't
have to maintain five versions of the code. See T12812.

Test Plan:
Before: {F8171128}

After: {F8171127}

Reviewers: #plasma, dantti, cblack, ndavis

Reviewed By: cblack, ndavis

Subscribers: cblack, sefaeyeoglu, kde-utils-devel

Differential Revision: https://phabricator.kde.org/D27995

M  +5    -9    plasmoid/package/contents/ui/PrinterItem.qml

https://commits.kde.org/print-manager/faea0b125911820c2c574cf17457f2d15c6100ba