Bug 398671 - Unusable folding code with python
Summary: Unusable folding code with python
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: folding (show other bugs)
Version: 18.08.1
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
: 398840 398845 398884 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-09-15 14:22 UTC by picotmathieu
Modified: 2018-09-20 18:52 UTC (History)
6 users (show)

See Also:
Latest Commit: https://cgit.kde.org/ktexteditor.git/commit/?id=6a35a902c9697b16376fc68848fee5b978881b71
Version Fixed In: 5.51
Sentry Crash Report:

Attachments
Screen capture of python code and nodes (245.15 KB, image/png)
2018-09-16 18:55 UTC, picotmathieu 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description picotmathieu 2018-09-15 14:22:28 UTC 
Since this new version (or attached frameworks), folding code is not working correctly with python files. It becomes simply unusable.
It detects nodes in many many places where there are not, and it becomes impossible to fold/unfold the true nodes.
Clicking on a wrong node doesn't make it disappears anymore.
Comment 1 JanKusanagi 2018-09-15 15:02:08 UTC 
I suggest specifying your version of KDE Frameworks, since there's no such thing as "attached frameworks".
Comment 3 Christoph Cullmann 2018-09-16 10:44:46 UTC 
Perhaps that was fixed, but actually one would need some example what precisely was wrong.
Comment 4 Dominik Haumann 2018-09-16 13:17:43 UTC 
Hm, the change is unrelated. Can you provide a screenshot?
Comment 5 Nate Graham 2018-09-16 14:22:48 UTC 
Darn, let's re-open then.
Comment 6 picotmathieu 2018-09-16 18:55:24 UTC 
Created attachment 115022 [details]
Screen capture of python code and nodes
Comment 7 Nate Graham 2018-09-16 18:58:02 UTC 
Yep, pretty sure that was fixed by https://cgit.kde.org/ktexteditor.git/commit/?id=6a35a902c9697b16376fc68848fee5b978881b71, but I'll let Dominik confirm. :)
Comment 8 picotmathieu 2018-09-16 18:59:49 UTC 
So I use a neon based distribution, currently with KDE Frameworks 5.50.0, kate version is 18.08.1.
I didn't have time for coding this summer, so I can't know sinche when this problem is here.
On the screenshot you can see that there are many nodes for folding codes that shouldn't exists. 
Previously, a wrong node was something that could appears, but clicking on it made it erase. Now It doesn't make anything.
Comment 9 Christoph Cullmann 2018-09-17 05:10:24 UTC 
Yeah, that is fixed.
But just to confirm: you can still fold all things that should be foldable, the only issue that is there is that some lines have markers that have nothing to fold (as e.g. for (......) the region ends in the same line as it starts).
Comment 10 picotmathieu 2018-09-17 07:03:08 UTC 
I can fold/Unfold true nodes only in the rare case that there is no wrong node inside. If there is one or more wrong node inside, click on a true node makes nothing.
Comment 11 Nate Graham 2018-09-18 13:41:04 UTC 
OK, so then this is indeed already fixed by https://cgit.kde.org/ktexteditor.git/commit/?id=6a35a902c9697b16376fc68848fee5b978881b71. :)
Comment 12 Dominik Haumann 2018-09-18 20:20:14 UTC 
Sorry for the noise :-)
Comment 13 Nate Graham 2018-09-18 20:28:11 UTC 
Not a problem!
Comment 14 Christoph Feck 2018-09-19 21:41:47 UTC 
*** Bug 398840 has been marked as a duplicate of this bug. ***
Comment 15 Christoph Feck 2018-09-19 21:41:57 UTC 
*** Bug 398845 has been marked as a duplicate of this bug. ***
Comment 16 Christoph Cullmann 2018-09-20 18:52:04 UTC 
*** Bug 398884 has been marked as a duplicate of this bug. ***