Bug 398670 - Tuen Ng Festival date in 2019 is wrong
Summary: Tuen Ng Festival date in 2019 is wrong
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kholidays
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-15 13:54 UTC by Michael Tsang
Modified: 2018-09-15 14:18 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/kholidays/eb1d23a58f903e06651fb2f461926c01c76934a1
Version Fixed In: 5.51.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Tsang 2018-09-15 13:54:45 UTC 
The date of Tuen Ng Festival in Hong Kong is wrong in korganizer. The
calendar shows 7 May 2019, however, according to the gov't website, it
should be 7 June 2019.

The authoritative source can be found below.

https://www.gov.hk/en/about/abouthk/holiday/2019.htm
Comment 1 Sandro Knauß 2018-09-15 14:16:06 UTC 
Is there any algorithm behind those dates?

You may want to have a look at the source file, there are the holidays until 2030. There may be more mistakes:
https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_hk_en-gb
https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_hk_zh-cn

Maybe you update the files and attach them here, than we can create a patch.
Comment 2 Allen Winter 2018-09-15 14:18:15 UTC 
Git commit eb1d23a58f903e06651fb2f461926c01c76934a1 by Allen Winter.
Committed on 15/09/2018 at 14:16.
Pushed by winterz into branch 'master'.

holiday_hk_* - fix date for Tuen Ng Festival in 2019
FIXED-IN: 5.51.0

M  +1    -1    holidays/plan2/holiday_hk_en-gb
M  +1    -1    holidays/plan2/holiday_hk_zh-cn

https://commits.kde.org/kholidays/eb1d23a58f903e06651fb2f461926c01c76934a1