Bug 398643 - Selection tool shouldn't automatically turn into move selection tool
Summary: Selection tool shouldn't automatically turn into move selection tool
Status: RESOLVED NOT A BUG
Alias: None
Product: krita
Classification: Applications
Component: Tools/Selection (other bugs)
Version First Reported In: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-14 21:53 UTC by Storm Engineer
Modified: 2018-09-15 07:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Storm Engineer 2018-09-14 21:53:26 UTC
Recently the selection tool behavior changed.

Expected behavior: The selection tool is always the selection tool.

Actual behavior: The selection tool automatically turns into move selection tool when over an existing selection. The user is forced to hold down the modifier key of the respective selection mode (replace, Add, etc.) just to stop this automatic behavior.

This is a reversed logic: A tool changing into another tool on its own as we move it around, and having to hold down a key just to stop this and preserve the behavior we set it to. Moreover I have to hold a different key to preserve its behavior based on which mode I was in. This is confusing, inconsistent and counter-intuitive.

Suggestion: Changing into a move selection tool should be invoked by holding a modifier key instead. This is more predictable and consistent behavior for both the selection and the move selection tools.

Note: I understand the demand for an easy way to move selections, but automatically changing tools based on if the cursor is inside or outside the selection outline makes much less sense (esp. in case of complex selections) than changing them precisely when we want, and only if we want, via holding down a key.
Comment 1 Storm Engineer 2018-09-14 21:56:07 UTC
To see how the current behavior can go real bad create a complex selection, eg. by selecting on-continuous color ranges. This can result in a complex map of areas inside and outside the selection outline.

Now if you mover your cursor around your tool will perform a magic act: Now I'm selection tool... no wait, I'm move tool... no wait, I'm selection tool again!
Comment 2 Halla Rempt 2018-09-15 07:49:07 UTC
Sorry, I understand your point, but this isn't a topic for a bug report. Bug reports are about things in the code that don't work as intended, and this does work as intended. You should have discussed this on phabricator: https://phabricator.kde.org/T9486