Bug 398626 - Media controls became invisible but still work
Summary: Media controls became invisible but still work
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Media Player widget (show other bugs)
Version: 5.14.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords:
: 399579 399663 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-09-14 17:26 UTC by Matej Mrenica
Modified: 2018-10-17 07:43 UTC (History)
11 users (show)

See Also:
Latest Commit: https://github.com/KDE/plasma-framework/commit/85cab5772c560ea248c490d9d58db87296dec06b#diff-9f37d30167b8f0a2233d75dddd05e4c6
Version Fixed In: 5.51
Sentry Crash Report:

Attachments
Screenshot of invisible controls (672.68 KB, image/png)
2018-09-14 17:26 UTC, Matej Mrenica 		Details
Screenshot of invisible controls and no cover art (26.29 KB, image/png)
2018-10-09 14:32 UTC, Alex The Bassist 		Details
Display Manager Widget (19.54 KB, image/jpeg)
2018-10-11 09:32 UTC, David de Cos 		Details
Display Manager Widget after pressing Win+P (61.57 KB, image/png)
2018-10-12 09:19 UTC, David de Cos 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2018-09-14 17:26:02 UTC 
Created attachment 114957 [details]
Screenshot of invisible controls

Affects every player and every icon theme.
Comment 1 Patrick Silva 2018-09-14 22:28:26 UTC 
yes, buttons to control the player are invisible here too.
I also use plasma 5.14 on Arch Linux.
Comment 2 Kai Uwe Broulik 2018-09-17 08:21:50 UTC 
What Qt versions are you using? Looks caused by the port to QtQuick Controls 2 but I cannot reproduce locally here. This is Breeze dark, right?
Comment 3 Sefa Eyeoglu 2018-09-17 08:27:19 UTC 
I (not the OP) am using Qt 5.11.1 and Breeze Dark. 
I am also on Arch
Comment 4 Matej Mrenica 2018-09-17 08:37:14 UTC 
OP: Qt 5.11.1, Arch Linux, Breeze Light + Breeze AlphaBlack
Comment 5 Marco Martin 2018-09-17 11:53:22 UTC 
(In reply to mthw0 from comment #4)
> OP: Qt 5.11.1, Arch Linux, Breeze Light + Breeze AlphaBlack

happens only with Breeze AlphaBlack or also with other plasma themes?
Comment 6 Sefa Eyeoglu 2018-09-17 11:58:15 UTC 
(In reply to Marco Martin from comment #5)
> (In reply to mthw0 from comment #4)
> > OP: Qt 5.11.1, Arch Linux, Breeze Light + Breeze AlphaBlack
> 
> happens only with Breeze AlphaBlack or also with other plasma themes?

Well it happens with Breeze Dark on my system at least.
Comment 7 Matej Mrenica 2018-09-17 12:30:52 UTC 
(In reply to Marco Martin from comment #5)
> (In reply to mthw0 from comment #4)
> > OP: Qt 5.11.1, Arch Linux, Breeze Light + Breeze AlphaBlack
> 
> happens only with Breeze AlphaBlack or also with other plasma themes?

It happens with all themes I have installed: Breeze (all variants), Arc, Adapta, Breath, Materia,...
Comment 8 Matej Mrenica 2018-10-05 18:05:02 UTC 
(In reply to mthw0 from comment #4)
> OP: Qt 5.11.1, Arch Linux, Breeze Light + Breeze AlphaBlack

Also Qt5.12-beta1
Comment 9 Alex The Bassist 2018-10-09 14:32:35 UTC 
Created attachment 115517 [details]
Screenshot of invisible controls and no cover art
Comment 10 Alex The Bassist 2018-10-09 14:34:40 UTC 
Same on KDE Neon here, but the cover art is also missing. See the screenshot above.
Comment 11 Patrick Silva 2018-10-10 00:11:04 UTC 
*** Bug 399579 has been marked as a duplicate of this bug. ***
Comment 12 Neousr 2018-10-10 00:19:21 UTC 
Can confirm the same behavior on Neon User Edition 5.14.

QT version 5.11.1
KDE frameworks 5.50.0

Such as:

- Functional invisible media controls (Even KDE Store themes)
- Cover art (From browser-integration and media players) 

Sometimes some covers appear but it seems to depend on the player used.
Comment 13 Chris Holland 2018-10-10 05:03:12 UTC 
I believe this is caused by the transition to PlasmaComponents3.

I'm using the same icons in my Win7 Mixer widget (using PlasmaComponent2), and those are still working. https://i.imgur.com/4BdZ2Mk.png

Changing mediacontroller back to PlasmaComponents2 (and changing `icon.name` => `iconName`) fixed it. https://i.imgur.com/66bp8ox.png
Comment 14 Chris Holland 2018-10-10 05:16:18 UTC 
Looks like:
/usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/components.3/ToolButton.qml

Doesn't have the "icon feature" added in a recent commit:
https://github.com/KDE/plasma-framework/commit/85cab5772c560ea248c490d9d58db87296dec06b#diff-9f37d30167b8f0a2233d75dddd05e4c6

I assume that commit will be part of KDE Frameworks 5.51 released this Saturday Oct 13th.
https://phabricator.kde.org/calendar/
Comment 15 Nate Graham 2018-10-10 12:29:46 UTC 
Looks like you're right, Chris!
Comment 16 David de Cos 2018-10-11 09:32:14 UTC 
Created attachment 115559 [details]
Display Manager Widget

Can I assume the empty icons in my Display Manager Widget are due to the same bug, or should I open a new one?
Comment 17 Matej Mrenica 2018-10-11 10:33:20 UTC 
(In reply to David de Cos from comment #16)
> Created attachment 115559 [details]
> Display Manager Widget
> 
> Can I assume the empty icons in my Display Manager Widget are due to the
> same bug, or should I open a new one?

I would say it's the same bug.
Comment 18 Chris Holland 2018-10-11 11:16:27 UTC 
> Can I assume the empty icons in my Display Manager Widget are due to the same bug, or should I open a new one?

If it's the same widget (Display Configuration) that's in the KScreen repository, then no it's not the same bug. That widget is using PlasmaComponents2. Actually, it's using a PlasmaCore.IconItem overtop a PlasmaComponents2.Button so it ignores the button's padding.

I cannot reproduce that bug: https://i.imgur.com/8exSQ11.png

* https://github.com/KDE/kscreen/blob/master/plasmoid/package/metadata.desktop
* https://github.com/KDE/kscreen/blame/master/plasmoid/package/contents/ui/ScreenLayoutSelection.qml#L75

Do the icons also not show up when you press `Win+P`?

Do you have /usr/share/icons/breeze/applets/64/osd-duplicate.svg

The icons haven't changed either.

* https://github.com/KDE/kscreen/blame/master/plasmoid/package/contents/ui/main.qml#L59
* https://github.com/KDE/kscreen/blame/master/kded/osdaction.cpp#L61
* https://github.com/KDE/breeze-icons/blob/master/icons-dark/applets/64/osd-duplicate.svg

Make sure you report what Desktop Theme + Icon Theme you're using when you make the bug report.

https://bugs.kde.org/enter_bug.cgi?product=KScreen&component=Plasma%20Applet
Comment 19 Nate Graham 2018-10-11 15:44:18 UTC 
*** Bug 399663 has been marked as a duplicate of this bug. ***
Comment 20 David de Cos 2018-10-12 09:19:57 UTC 
Created attachment 115593 [details]
Display Manager Widget after pressing Win+P

> Do the icons also not show up when you press `Win+P`?

Only the last one, and I'm not sure that's the icon that should be displayed. See the attached screenshot.


> Do you have /usr/share/icons/breeze/applets/64/osd-duplicate.svg

I do, but I'm using the Oxygen icon theme.


> Make sure you report what Desktop Theme + Icon Theme you're using when you make the bug report.

I will. Just in case it helps here:

- Desktop theme: Breeze Transparent Dark
- Icon theme: Oxygen
Comment 21 Ben Cooksley 2018-10-17 07:43:09 UTC 
Removing subscriber per abuse report we received.