Bug 398617 - Project/Configure Selection does not take qmake extra arguments into account
Summary: Project/Configure Selection does not take qmake extra arguments into account
Status: REPORTED
Alias: None
Product: kdevelop
Classification: Applications
Component: Build tools: QMake (show other bugs)
Version: 5.2.80
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2018-09-14 12:55 UTC by RJVB
Modified: 2021-01-26 13:15 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description RJVB 2018-09-14 12:55:34 UTC
Using Project/Configure Selection simply runs the selected QMake executable on the project source tree but fails to take any extra arguments into account (say, -spec linux-clang).

Running QMake directly via the Project Manager's context menu works correctly AFAICT.
Comment 1 Kevin Funk 2018-09-14 16:02:29 UTC
Source code hint: Check kdevelop.git:plugins/qmakemanager -- start by grepping for 'args' or 'extraArguments'.

This is probably easy to fix. Look into CMake support to find inspiration how to solve.
Comment 2 Kevin Funk 2018-09-14 16:02:58 UTC
Note: Just a hint if someone wants to pick this up; not meant to RJVB directly.
Comment 3 RJVB 2018-09-14 18:48:02 UTC
> not meant to RJVB directly.

Didn't take it that way (but I'd have figured out a fix if I used QMake projects more often).

(And thanks for correcting the subject. Usually I notice when my sh*tty notebook keyboard didn't register a stroke...)
Comment 4 Wouter Haffmans 2021-01-26 13:15:14 UTC
This bug is still present in KDevelop 5.6.1.

It looks like both the QMake Builder and QMake Manager plugins have a QMakeJob class in the code, but they differ quite a bit. The latter plugin adds the "Run QMake" context menu entry, which works correctly (see QMakeProjectManager::slotRunQMake where it adds the arguments to the job).

It looks like part of that code should be added/moved to QMakeBuilder::configure to fix this.