Bug 398595 - Untranslatable messages in installation reminder
Summary: Untranslatable messages in installation reminder
Status: RESOLVED FIXED
Alias: None
Product: plasma-browser-integration
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-13 22:44 UTC by Alexander Potashev
Modified: 2018-09-14 14:28 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/plasma-browser-integration/715ba3a22906cb1c64297985531511bcc91b7bbb
Version Fixed In: 5.14.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2018-09-13 22:44:14 UTC 
These strings from plasma-browser-integration are never extracted into .pot templates and thus are untranslatable:

reminder/browserintegrationreminder.cpp:    m_sni->setTitle(i18n("Get Plasma Browser Integration"));
reminder/browserintegrationreminder.cpp:    auto *action = new QAction(i18n("Do not show again"));
Comment 1 Kai Uwe Broulik 2018-09-14 07:37:40 UTC 
I'm not sure how that works with StacicMessage.sh. David, can we just dump a classic c++ extraction Messages.sh in there as well?
Comment 2 Kai Uwe Broulik 2018-09-14 14:28:18 UTC 
Git commit 715ba3a22906cb1c64297985531511bcc91b7bbb by Kai Uwe Broulik.
Committed on 14/09/2018 at 14:27.
Pushed by broulik into branch 'Plasma/5.14'.

Add Messages.sh

We have translatable strings in the reminder c++ code.
FIXED-IN: 5.14.0

Differential Revision: https://phabricator.kde.org/D15495

M  +2    -0    reminder/CMakeLists.txt
A  +2    -0    reminder/Messages.sh

https://commits.kde.org/plasma-browser-integration/715ba3a22906cb1c64297985531511bcc91b7bbb