Bug 398510 - The Background Contrast effect ignores data.brightness() and data.saturation()
Summary: The Background Contrast effect ignores data.brightness() and data.saturation()
Status: RESOLVED WORKSFORME
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (show other bugs)
Version: git master
Platform: Other Linux
: LO normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-11 16:17 UTC by Vlad Zahorodnii
Modified: 2021-12-06 04:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vlad Zahorodnii 2018-09-11 16:17:31 UTC
Steps to reproduce:
* [enable the kscreen effect];
* Set "Animation speed" to "Very slow";
* Lock screen.

Expected results:
* The panel fades to black;

Actual results:
* The panel stays bright.
Comment 1 Vlad Zahorodnii 2018-09-11 18:20:30 UTC
The problem is that content of the panel is translucent.

W.r.t. the blur effect, it makes sense to not modulate blurred stuff with 
"brightness and saturation".

On the other hand, with the background contrast effect, things are a little bit different... I'm not sure whether that's a bug at all.

Anyway, I can think of 2 potential solutions:
* copy and increase contrast in a single pass, then use a shader from libkwineffects to map and also modulate the result;
* copy what's underneath, then increase contrast and "modulate" in a single pass(e.g. by tweaking color matrix).

I'm lowering priority of this bug report because it's really hard to notice this bug(?).
Comment 2 David Edmundson 2018-09-17 16:42:12 UTC
> I'm not sure whether that's a bug at all.

It If you draw custom content for a window, it should follow the relevant WindowPaintData. Contrast already follows translations and opacity, it does makes sense that it should follow brightness/whatever elese.

As for the suggestions, I don't think 2 is too difficult, we just add a uniform and one multiply of the rgb...

but I also agree that you can't really see it, so it's not really worth doing too much.
Comment 3 kde.org 2021-11-06 21:44:41 UTC
This issue report is quite old. Can you please confirm, that it still persists with KDE 5.23?
Comment 4 Bug Janitor Service 2021-11-21 04:40:24 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2021-12-06 04:39:39 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!