Bug 398478 - User Interface crashes when clip job stabilizing and adding .mlt automatically
Summary: User Interface crashes when clip job stabilizing and adding .mlt automatically
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: Appimage - Refactoring
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords: junior-jobs
: 382333 382854 383201 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-09-11 08:47 UTC by Evert Vorster
Modified: 2019-02-24 06:26 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
fritzibaby: Brainstorm+
fritzibaby: low_hanging+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Evert Vorster 2018-09-11 08:47:10 UTC
Latest release branch from git 18.08 crashes when automatically adding a clip to the project after it has been stabilized with the clip job vidstab.

If you want a back trace I would be happy to oblige. 

-Evert-
Comment 1 Evert Vorster 2018-09-11 09:31:44 UTC
When running from the console, I get this error message when the crash occurs:


----------------snip----------------------
New Thread 0x7ffec47e8700 (LWP 6983)]
[New Thread 0x7ffec4fe9700 (LWP 6984)]
[New Thread 0x7ffec57ea700 (LWP 6985)]
[New Thread 0x7ffec5feb700 (LWP 6986)]
[New Thread 0x7fff31a52700 (LWP 6987)]
[New Thread 0x7fff31251700 (LWP 6988)]
[New Thread 0x7fff30a50700 (LWP 6989)]
[New Thread 0x7ffef3fff700 (LWP 6990)]
[New Thread 0x7ffe537fe700 (LWP 6991)]
[IMGUTILS @ 0x7ffeb2ffc6f0] Picture size 1701277281x100 is invalid
Cannot allocate memory.
sws: initFilter failed
[New Thread 0x7ffdb5ffa700 (LWP 6992)]

Thread 1301 "Thread (pooled)" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffeb2ffd700 (LWP 6964)]
0x00007ffff506abb5 in __memmove_sse2_unaligned_erms () from /usr/lib/libc.so.6
(gdb)
Comment 2 emohr 2018-09-11 10:05:36 UTC
What do you have for a strange Picture size: 1’701’277’281x100
1 Billion, 701 million, … length and just 100 pixel high.
Comment 3 Evert Vorster 2018-09-19 06:59:58 UTC
To elaborate a bit more...

I right-click on a clip in the project bin, select clip jobs, then stabilize. On the menu that pops up, I select automatically add to project. 
I can then see the clip is being analyzed with it's little progress indicator, but when the time comes to add the .mlt file to the project, the whole UI disappears with a segfault. 


So, two things are wrong.
1. an invalid .mlt file is being generated. 
2. the UI segfaults, rather than give an error message. 

Now, I have tried this with latest packages from Arch Linux for both kdenlive and mlt, and the segfault still occurs. 

I have now (2018-09-18) compiled mlt from git, the latest master branch, and kdenlive from latest application 18.08 branch, and now it looks like the .mlt files being generated at least don't segfault the UI anymore, but they still have a lot of issues, outside the scope of this bug. The git logs of both applications do not have anything obvious about .mlt file generation in them recently, which is weird.

However, bottom line is that the UI should not segfault just because an input file is invalid, and an error message indicating that the stabilization failed and maybe the output from console for that bit would be a nice touch. It would certainly help for more clear bug reports.
Comment 4 emohr 2018-12-26 15:43:39 UTC
Do you use the VideoStab with right click on the clip (Videostab2) which is outdated or do you use VidStab under the effects? For VidStab under effect here some explanation of the values: https://www.mltframework.org/plugins/FilterVidstab/
Comment 5 emohr 2018-12-27 19:13:04 UTC
*** Bug 382854 has been marked as a duplicate of this bug. ***
Comment 6 emohr 2018-12-27 19:19:07 UTC
*** Bug 382333 has been marked as a duplicate of this bug. ***
Comment 7 emohr 2018-12-27 19:26:04 UTC
*** Bug 383201 has been marked as a duplicate of this bug. ***
Comment 8 emohr 2018-12-27 19:35:51 UTC
I change the version to refactoring timeline as this version is affected as well.
Comment 9 Evert Vorster 2019-01-02 05:46:58 UTC
emohr, please read comment #3.

I use Vidstab2, from the clip jobs in the context menu from the project bin.

TLDR #1; The UI should not crash from normal user input.
TLDR #2; That job generates invalid .mlt file

Kind regards,
Evert
Comment 10 emohr 2019-01-04 16:46:03 UTC
Hi Evert. Yes I read comment 3 but I see the link is missing that Vidstab2 is deprecated. More details here: hhttps://www.mltframework.org/plugins/FilterVideostab2/ and here https://sourceforge.net/p/mlt/bugs/185/

So I understand we should not use Videostab2 anymore.
Comment 11 Evert Vorster 2019-01-06 04:42:59 UTC
Hi there, emohr. 

To re-iterate from comment #3. 
1. an invalid .mlt file is being generated.
2. UI crashes with invalid input. 

If changing the backend vid.stab in project manager clip jobs will fix #1, then maybe it's something that needs to be done. 

That still leaves #2... The error handling on input files of the UI needs work. 

Personally, I use Blender 3D to stabilize and render these days.
Kind regards,
-Evert-
Comment 12 Evert Vorster 2019-02-24 06:26:03 UTC
Stabilizations on the clip jobs are now automatically added, and does not crash the UI