Bug 398429 - KRename process not terminating
Summary: KRename process not terminating
Status: RESOLVED FIXED
Alias: None
Product: krename
Classification: Applications
Component: general (show other bugs)
Version: 5.0.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Heiko Becker
URL:
Keywords: investigated, triaged
: 438034 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-09-09 15:14 UTC by daniel roi
Modified: 2021-06-03 17:42 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description daniel roi 2018-09-09 15:14:27 UTC
When I run KRename from Dolphin's action menu and use the Find and Replace button, I can close the window using the Close button or by pressing ESC. The krename process however does not terminate.

The problem with the Close button has been fixed (issue 395084) but when using the ESC button I still see krename in ps -aux:

user   17402  0.0  0.4 511656 71340 ?        Sl   16:43   0:01 /usr/bin/krename /home/user/file1.pdf /home/user/file2.pdf

user   25883  0.0  0.1 148388 17356 ?        S    17:09   0:00 file.so [kdeinit5] file local:/run/user/1000/klauncherCxmAnz.1.slave-socket local:/run/user/1000/krenameyDpvAk.1.slave-socket

I'm using the latest git version (r485.9a24890).
Comment 1 Thomas Piekarski 2018-09-09 18:12:30 UTC
Hello,

I tried to reproduce the bug you reported, but I can not close the window of KRename by pressing Esc when in front the "Find and Replace" window is open.

The only window I am able to close is Dolphin itself, you didn't mean that window, did you? :)

Can you provide any other information which could help us to reproduce this bug?

Tested Versions:
krename 5.0.60 (built from most recent commit #9a24890 like you did)
dolphin 18.08.1
Comment 2 daniel roi 2018-09-10 12:32:44 UTC
I've tried again right now. This is what I do:

1. select some files in Dolphin and go to Actions > Rename with Krename
2. click the Find and Replace button
3. click Add, enter something, click Ok, and Ok again
4. click Finish: the "Progress" window appears
5. press Esc: the window closes
6. ps -aux returns this:

user    6212  4.1  0.4 512288 72728 ?        Sl   14:28   0:00 /usr/bin/krename /data/test1 /data/test2
user    6217  0.0  0.1 148388 17428 ?        S    14:28   0:00 file.so [kdeinit5] file local:/run/user/1000/klauncherxFtyvb.1.slave-socket local:/run/user/1000/krenameFEAZUH.1.slave-socket
user    6218  0.0  0.1 148388 17428 ?        S    14:28   0:00 file.so [kdeinit5] file local:/run/user/1000/klauncherxFtyvb.1.slave-socket local:/run/user/1000/krenamexzcmha.2.slave-socket
Comment 3 Thomas Piekarski 2018-09-10 13:09:52 UTC
(In reply to daniel roi from comment #2)
> I've tried again right now. This is what I do:

Thanks for the steps you described, I can confirm and reproduce this bug.
Comment 4 daniel roi 2019-02-03 16:48:46 UTC
Any news about this bug?
Comment 5 Christoph Feck 2019-02-22 18:15:29 UTC
According to bug 395084 this should be fixed in master. If you distribution does not offer test builds of unreleased versions, you would need to compile yourself to confirm the fix.
Comment 6 Mihai Sorin Dobrescu 2020-07-05 07:52:05 UTC
Hi, My system is:

Operating System: Gentoo Linux
KDE Plasma Version: 5.19.2
KDE Frameworks Version: 5.71.0
Qt Version: 5.15.0
Kernel Version: 5.6.0-sabayon
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7 CPU 920 @ 2.67GHz
Memory: 23,5 GiB of RAM
Graphics Processor: GeForce GTX 1060 6GB/PCIe/SSE2

The bug is still present.
As effect, KRename is restored at login in many instances, when the session restore is set.
Comment 7 Han Prower 2020-07-26 12:49:18 UTC
I too experience an issue with krename not terminating correctly when it is closed.

krename output when ran via Konsole (I slightly tided up the output for readability):

kf5.kio.core: "Could not enter folder tags:/."
kf5.kio.core: We got some errors while running testparm "Unknown parameter encountered: "write cache size"
Ignoring unknown parameter "write cache size"
Loaded services file OK."
kf5.kio.core: We got some errors while running 'net usershare info'
kf5.kio.core: "Unknown parameter encountered: "write cache size"
Ignoring unknown parameter "write cache size"
Unknown parameter encountered: "write cache size"
Ignoring unknown parameter "write cache size"
info_fn: file /var/lib/samba/usershares/esoaddons is not a well formed usershare file.
info_fn: Error was Path is not a directory.
"
QObject::connect(KRenameModel, KRenameWindow): invalid nullptr parameter

And then the process remains.

On additional runs krename will hang the plasmashell until it finally struggles through its process. It can take 30 - 300 seconds to do so.
Comment 8 S. Christian Collins 2020-08-03 15:36:00 UTC
I just compiled the latest master from git (version 5.0.60), and this problem appears to be fixed.
Comment 9 Heiko Becker 2020-10-08 12:18:19 UTC
Can you please try again with 5.0.1? I suspect it's a duplicated of bug 395084 which was confirmed fixed.
Comment 10 Heiko Becker 2020-10-08 12:19:07 UTC
settings to NEEDSINFO until then
Comment 11 Mihai Sorin Dobrescu 2020-10-08 13:06:06 UTC
I will when my distro will provide it. So far is still 5.0.0.
Comment 12 Han Prower 2020-10-08 14:18:52 UTC
I can confirm processes seem to terminate correctly on 5.0.1.
Comment 13 Heiko Becker 2020-10-08 16:21:35 UTC
Thanks for the feedback!
Comment 14 Heiko Becker 2021-06-03 17:42:27 UTC
*** Bug 438034 has been marked as a duplicate of this bug. ***