Bug 398339 - Gamut mask does not update
Summary: Gamut mask does not update
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Dockers (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Anna Medonosova
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-06 20:32 UTC by brusheco
Modified: 2018-10-04 15:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Gamut mask bug (202.67 KB, video/mp4)
2018-09-30 10:36 UTC, brusheco
Details
gamut mask bug 2 (124.38 KB, video/mp4)
2018-09-30 15:28 UTC, brusheco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description brusheco 2018-09-06 20:32:23 UTC
When editing a gamut mask, the image in the gamut mask docker updates, but it doesn't update in the artistic color selector, it just shows the original.

1. Click edit gamut mask in gamut mask docker.
2. Transform or rotate the mask
3. save new mask with different name
4. you should see that the mask has not updated in the artistic colour selector docker.

Using windows 7 64bit
Krita git fb16dc5
Comment 1 Anna Medonosova 2018-09-13 14:30:52 UTC
I am sorry, I cannot reproduce your issue. Could you please test a more recent nightly build and if the problem persists, specify the steps to reproduce in more detail, or upload a screen recording showing the issue?
Comment 2 Andrew Crouthamel 2018-09-30 02:44:23 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 brusheco 2018-09-30 10:36:17 UTC
Created attachment 115325 [details]
Gamut mask bug

In the video I click on the different gamut masks, and as you can see, they don't show up properly in the artistic color selector docker.
Comment 4 brusheco 2018-09-30 10:41:19 UTC
I should add that this isn't what was happening in the original report, but since i've downloaded a more recent build (g1b50235ce3) for some reason the older build that this report comes (git fb16dc5) produces the exact same bug in the video attached. So there was no way for me to show what was originally happening.
Comment 5 Anna Medonosova 2018-09-30 15:04:39 UTC
Good afternoon,

from what I can see in the video, I think that you have checked "Invert saturation" in the wheel preferences and also "Enforce gamut mask" in "Gamut Mask Behavior" section of the settings menu. In that combination of settings the displayed behavior is intended.

The gamut mask is based off a wheel with gray in the center and the most saturated colors on the perimeter. When you invert saturation in the selector and "Enforce gamut mask" is on, the wheel shows the swatches which would fall inside the mask with default saturation rings order. It kind of turns the mask inside out.

If you wish to see the mask shape as it is in the thumbnail, with inverted saturation, you can set the "Gamut Mask Behavior" to "Just show the shapes". Or you can leave the "Enforce gamut mask" setting and uncheck "Inverted saturation".
Comment 6 brusheco 2018-09-30 15:28:08 UTC
Created attachment 115329 [details]
gamut mask bug 2

Hi, I fixed what you said, and it displays as before. However now the original issue is still present, I attached a new video, you can see has I go through the gamut masks, they all update, except for the last one which I created myself.
Comment 7 Anna Medonosova 2018-09-30 16:03:30 UTC
Thanks for the video.

The color selector uses the raw SVG shapes, so when you use some function like "Layer" -> "Transform" -> "Rotate", or similar, it unfortunately has no effect on the gamut mask. Currently the only way is to select the shapes and rotate them "by hand", with the mouse, or in the tool options docker. If you edited the shapes by hand and the problem persists, could you please attach your newly created gamut mask to this bug?

Please note, that a much simpler way to rotate the existing gamut masks is being actively developed.
Comment 8 brusheco 2018-10-01 11:10:48 UTC
hi anna, where do I find the file, or is it attached to the kra. file?, the one i've made isn't actually for use, I was just testing to see if I could make my own.

When I made the mask I didn't use the canvas transform, I used (ctrl t) transform too. It seems that when you duplicate and edit a mask and save it, the changes aren't actually being saved, only the thumbnail preview.

When you create a completely brand new mask and save it works fine.

It seems like the future rotation tool will answer my problems
Comment 9 Anna Medonosova 2018-10-02 15:58:26 UTC
The good news is that the simple way to rotate masks should be in the next nightly build (look for the 'Rotation' slider on top of the color selector).

Unfortunately, the transformations done through the transform tool cannot be saved in a gamut mask. The only way to rotate the shapes is to drag them by the bent arrow icon (https://docs.krita.org/en/reference_manual/layers_and_masks/vector_layers.html?highlight=rotate#rotate).

I think you do not need to attach the mask as I was able to reproduce the issue. But for completeness: the gamut mask can be exported to a bundle in the resource manager (https://docs.krita.org/en/reference_manual/resource_management.html?highlight=create%20bundle#creating-your-own-bundle).
Comment 10 brusheco 2018-10-02 17:26:36 UTC
I think i've wasted time with this report,i've never really used vector tools in krita, apologies. I have now successfully used "select shape tool" to do the rotations instead of the transform tool.

Will try out the new feature tomorrow.
Comment 11 Anna Medonosova 2018-10-04 15:10:50 UTC
For clarity, I have created a separate bug for the transform tool issue: https://bugs.kde.org/show_bug.cgi?id=399381

I'm closing this bug, as all other mentioned issues have been resolved.