Bug 398309 - Use icon or the word 'Edit' instead of 'Change' for editing tags and comments
Summary: Use icon or the word 'Edit' instead of 'Change' for editing tags and comments
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: information (show other bugs)
Version: 18.08.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-06 07:20 UTC by Michael D
Modified: 2018-09-09 04:23 UTC (History)
3 users (show)

See Also:
Latest Commit: https://commits.kde.org/baloo-widgets/f2f313f4e306a231abbdae7ac05b7711a424a01b
Version Fixed In: 18.12.0
Sentry Crash Report:
kde: Usability?

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Michael D 2018-09-06 07:20:34 UTC 
I think it would look better to use an icon (e.g. document-edit or document-edit-symbolic) instead of the word 'Change' for editing metadata such as tags and comments. Otherwise the word 'Edit' seems to be more common than 'Change'.
Comment 1 Nate Graham 2018-09-07 22:28:24 UTC 
Here, have a patch: https://phabricator.kde.org/D15332
Comment 2 Michael D 2018-09-08 07:12:42 UTC 
Cheers!
Comment 3 Nate Graham 2018-09-09 04:23:06 UTC 
Git commit f2f313f4e306a231abbdae7ac05b7711a424a01b by Nathaniel Graham.
Committed on 09/09/2018 at 04:22.
Pushed by ngraham into branch 'master'.

Use the more common string "Edit" in place of "Change"

Summary:
"Edit" is a more common string than "Change", so let's use that instead.
FIXED-IN: 18.12.0

Test Plan: {F6240816}

Reviewers: #dolphin, #vdg, broulik

Reviewed By: broulik

Subscribers: bruns, abetts, broulik, #baloo

Tags: #baloo

Differential Revision: https://phabricator.kde.org/D15332

M  +3    -3    src/kcommentwidget.cpp
M  +1    -1    src/kedittagsdialog.cpp
M  +1    -1    src/tagwidget.cpp

https://commits.kde.org/baloo-widgets/f2f313f4e306a231abbdae7ac05b7711a424a01b