Bug 398294 - Moving selections with the "Bezier Selection Tool"
Summary: Moving selections with the "Bezier Selection Tool"
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Selection (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-05 16:30 UTC by mvowada
Modified: 2019-09-13 09:59 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/kde/krita/commit/0ff5c48ab5abc4440072d07f34305a6b5885837a
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description mvowada 2018-09-05 16:30:04 UTC 
(krita-4.2.0-pre-alpha-bb79c0e-x86_64.appimage - Ubuntu 14.04, Unity)

I've noticed that only the "Bezier Selection Tool" doesn't allow moving just created selections (see also: https://forum.kde.org/viewtopic.php?f=139&t=153823 
):

    1. try to hover a selection with the "Bezier Selection Tool"

Actual Results: not possible to move the selection
Expected Results: allow moving the selection
Comment 1 Dmitry Kazakov 2019-09-09 10:52:38 UTC 
Git commit 8ff09e524486bd07cf3127ac1b0077c0ba618d8b by Dmitry Kazakov.
Committed on 09/09/2019 at 10:51.
Pushed by dkazakov into branch 'master'.

Fix move action in the Bezier Selection Tool

We should route all the mouse events via begin/continue/endPrimaryAction
path in KisDelegatedSelectPathWrapper to make sure that extra selection
actions implemented by KisToolSelectBase are available to the user.

M  +32   -17   plugins/tools/selectiontools/kis_tool_select_path.cc
M  +7    -1    plugins/tools/selectiontools/kis_tool_select_path.h

https://invent.kde.org/kde/krita/commit/8ff09e524486bd07cf3127ac1b0077c0ba618d8b
Comment 2 Dmitry Kazakov 2019-09-13 09:59:55 UTC 
Git commit 0ff5c48ab5abc4440072d07f34305a6b5885837a by Dmitry Kazakov.
Committed on 13/09/2019 at 09:00.
Pushed by dkazakov into branch 'krita/4.2'.

Fix move action in the Bezier Selection Tool

We should route all the mouse events via begin/continue/endPrimaryAction
path in KisDelegatedSelectPathWrapper to make sure that extra selection
actions implemented by KisToolSelectBase are available to the user.

M  +32   -17   plugins/tools/selectiontools/kis_tool_select_path.cc
M  +7    -1    plugins/tools/selectiontools/kis_tool_select_path.h

https://invent.kde.org/kde/krita/commit/0ff5c48ab5abc4440072d07f34305a6b5885837a