Bug 398239 - Filter “Delogo” is not configurable (-1 for all parameters) and has no effect
Summary: Filter “Delogo” is not configurable (-1 for all parameters) and has no effect
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Effects & Transitions (show other bugs)
Version: Appimage - Refactoring
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Vincent PINON
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2018-09-04 13:27 UTC by Dirk
Modified: 2021-02-26 05:17 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
fritzibaby: low_hanging+


Attachments
Screenshot from the filter’s configuration (10.90 KB, image/png)
2018-09-04 13:27 UTC, Dirk
Details
full logfile (5.61 KB, text/plain)
2018-09-04 13:29 UTC, Dirk
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk 2018-09-04 13:27:40 UTC
Created attachment 114770 [details]
Screenshot from the filter’s configuration

When trying to apply the Delogo filter (Rightclick on a track in the timeline -> Add effect -> Misc -> 0 - F -> Delogo) all four bars are unlabeled (av.x, av.y, av.w, av.h instead of … position and width/height names, I guess) and set to -1 without the possibility to change the values. See attached screenshot.

The log in the console says …

[delogo @ 0x7f82b9432d80] Option x was not set.
[filter avfilter.delogo] Cannot init filter: Invalid argument
[delogo @ 0x7f82b9432d80] Logo area is outside of the frame.
[filt @ 0x7f8238bf6ac0] Failed to configure input pad on filt
[filter avfilter.delogo] Cannot configure the filter graph

… when adding the filter.

This affects all types of video formats regardless of video source.
Comment 1 Dirk 2018-09-04 13:29:19 UTC
Created attachment 114771 [details]
full logfile

Full log file from starting Kdenlive, drag&dropping a video file to it, adding the clip to the timeline and trying to apply the filter.
Comment 2 emohr 2018-09-04 17:48:11 UTC
Do you have tried with the AppImage? If not try, because it seems something is not proper installed.
Comment 3 Vincent PINON 2018-09-04 20:22:30 UTC
Well, avfilters have been added for a while in MLT, and get exposed in Kdenlive, but we never added the filters UI files and then they don't get properly initialized.
This is not really a C++ coding task, more a matter of filling XML templates.
I'll try to do this in the next weeks.
Comment 4 emohr 2018-12-30 11:44:18 UTC
Still not working on Refactoring version.
Comment 5 Dirk 2019-01-05 03:53:14 UTC
(In reply to emohr from comment #4)
> Still not working on Refactoring version.

Can confirm not working in latest stable AppImage (18.12.0e) and installed version 18.12.0.
Comment 6 Dirk 2019-05-02 15:27:04 UTC
Still not working in installed version 18.12.3. Cannot check in latest available AppImage (19.04.0) because it seems like most of the filters are not available there (including - or better *not* including - the Delogo filter)
Comment 7 emohr 2019-05-02 17:41:44 UTC
Please try with the Kdenlive_Nightly_Appimage
https://binary-factory.kde.org/job/Kdenlive_Nightly_Appimage_Build/lastSuccessfulBuild/artifact/ 

There you can search for "delogo" (it's under the "filmstrip" icon).
Comment 8 Dirk 2019-05-03 12:48:49 UTC
Yes, the Delogo filter is there – but not configurable with same issues as in the initial bug report.
Comment 9 Christophe Agathon 2019-11-25 19:22:27 UTC
Still not there in installed version 18.12.3 (ubuntu)

If you want to give a try to delogo filter, you can add a delogo.xml file in /usr/share/kdenlive/effects containing the following :



<!DOCTYPE kpartgui>
<effect tag="avfilter.delogo" id="avfilter.delogo">
	<name>Delogo</name>
	<description>Remove Logo</description>
	<author>libavfilter maintainers</author>
	<parameter type="constant" name="av.x" max="%maxWidth" min="0" default="0" suffix="pixels">
		<name>Left</name>
	</parameter>
	<parameter type="constant" name="av.y" max="%maxHeight" min="0" default="0" suffix="pixels">
		<name>Top</name>
	</parameter>
	<parameter type="constant" name="av.w" max="%maxWidth" min="0" default="0" suffix="pixels">
		<name>Width</name>
	</parameter>
	<parameter type="constant" name="av.h" max="%maxHeight" min="0" default="0" suffix="pixels">
		<name>Height</name>
	</parameter>
</effect>



Just restart kdenlive and it should work pretty well.
Comment 10 Dirk 2020-04-27 04:27:09 UTC
Still not functional in the latest Kdenlive 20 release.

The manual addition of the XML file makes it possible use the filter but it does not work with the newly introduced preview scaling (but I guess that’s another issue)
Comment 11 Julius Künzel 2021-02-25 16:11:27 UTC
Due to the preview resolution issue the effect has been marked as deprecated since 20.12 so I am closing this now. You can simply use "Spot Remover" instead (it has the same effect but no issues and a better interface).
Comment 12 Dirk 2021-02-25 19:46:29 UTC
Actually no.

I just tried spot remove and when moving it on any axis it instantly 
blurs the whole video image.

Am 2021-02-25 17:11, schrieb Julius Künzel:
> https://bugs.kde.org/show_bug.cgi?id=398239
> 
> Julius Künzel <jk.kdedev@smartlab.uber.space> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|CONFIRMED                   |RESOLVED
>          Resolution|---                         |FIXED
>                  CC|                            
> |jk.kdedev@smartlab.uber.spa
>                    |                            |ce
> 
> --- Comment #11 from Julius Künzel <jk.kdedev@smartlab.uber.space> ---
> Due to the preview resolution issue the effect has been marked as 
> deprecated
> since 20.12 so I am closing this now. You can simply use "Spot Remover" 
> instead
> (it has the same effect but no issues and a better interface).
Comment 13 Julius Künzel 2021-02-25 21:56:02 UTC
You have to adjust the size to limit the effect to a certain area. Simply drag the red handles on the monitor (edit mode needs to be active) or use the effect /composition stack.
Comment 14 Dirk 2021-02-26 05:17:18 UTC
   It initially was limited to a certain area in the top left. By
   changing one of the values it seems like the area was expanded to the
   whole size of the video without me noticing it.
   Manually dragging the corners/center or adjusting the size afterwards
   works as expected. The filter works as described, thanks for the hint!

   Am 25.02.2021 22:56 schrieb Julius Künzel <bugzilla_noreply@kde.org>:

     https://bugs.kde.org/show_bug.cgi?id=398239

     --- Comment #13 from Julius Künzel <jk.kdedev@smartlab.uber.space>
     ---
     You have to adjust the size to limit the effect to a certain area.
     Simply drag
     the red handles on the monitor (edit mode needs to be active) or
     use the effect
     /composition stack.

     --
     You are receiving this mail because:
     You reported the bug.