Bug 398014 - Monochrome icons vanish when selected
Summary: Monochrome icons vanish when selected
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: icons mode (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: usability
: 393075 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-08-29 11:54 UTC by Fabian Vogt
Modified: 2018-09-04 07:01 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 18.08.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2018-08-29 11:54:10 UTC
The green selection background does not extend underneath the icon of a selected item. As monochrome icons change color to white when selected, this makes them invisible.
Comment 1 Patrick Silva 2018-08-29 16:00:55 UTC
duplicate of bug 393075 ?
Comment 2 Fabian Vogt 2018-08-29 17:07:55 UTC
(In reply to Dr. Chapatin from comment #1)
> duplicate of bug 393075 ?

Yes, but this one is more accurate so I'll mark that one as a dup of this.
Comment 3 Fabian Vogt 2018-08-29 17:08:15 UTC
*** Bug 393075 has been marked as a duplicate of this bug. ***
Comment 4 Kai Uwe Broulik 2018-09-04 07:01:36 UTC
Git commit b734386cbc8436a239d20df31253a870c4e6c936 by Kai Uwe Broulik.
Committed on 04/09/2018 at 07:01.
Pushed by broulik into branch 'Applications/18.08'.

Don't use QIcon::Selected state for selected icon

This causes selected monochrome Breeze icons to turn white as this state is meant for when the icon is actually painted ontop of
e.g. a blue highlighted area in a menu
Since the advanced icon configuration (where you could choose a custom hint color and other effects) has been removed in Plasma 5.13
and more importantly the fact that Dolphin always tints the icon in the highlight color disregarding any custom icon effects settings
this is an acceptable change.

CHANGELOG: Fixed monochrome icons turning invisible when selected
FIXED-IN: 18.08.2

Differential Revision: https://phabricator.kde.org/D15255

M  +1    -1    src/kitemviews/kstandarditemlistwidget.cpp

https://commits.kde.org/dolphin/b734386cbc8436a239d20df31253a870c4e6c936