Bug 397978 - translation kcm delegate remove button not state sensitive
Summary: translation kcm delegate remove button not state sensitive
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_language (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-28 09:31 UTC by Harald Sitter
Modified: 2021-01-05 23:22 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.21
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2018-08-28 09:31:42 UTC
on git master

- open kcm
- add a bunch languages
- in the list view use the delegate's remove button on the right hand side to remove the languages again
- for the the last language the remove button does nothing

the remove button should either be disabled or the last language ought to be removable (also see bug #397974).
Comment 1 Nate Graham 2021-01-05 23:20:22 UTC
Git commit 88d9e8f2292b02e9ad476d1f74e6561dfddd046d by Nate Graham.
Committed on 05/01/2021 at 23:18.
Pushed by ngraham into branch 'master'.

[kcms/translations] Don't show inline buttonsfor last list item

Removing the only item makes no conceptual sense, so let's not permit
it. Likewise, when there's only one item, it can't be moved to the top
since it's already at the top, so let's not show that one either.
FIXED-IN: 5.21

M  +3    -1    kcms/translations/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/88d9e8f2292b02e9ad476d1f74e6561dfddd046d
Comment 2 Luigi Toscano 2021-01-05 23:22:30 UTC
Please let the last language to be removed, so that people can restore the default system behavior. In fact my systems have no languages defined but they are localized.