Bug 397938 - "Update all" button should be disabled while Discover checks for updates
Summary: "Update all" button should be disabled while Discover checks for updates
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Updates (interactive) (show other bugs)
Version: 5.13.4
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords: junior-jobs, usability
Depends on:
Blocks:
 
Reported: 2018-08-27 17:06 UTC by Patrick Silva
Modified: 2018-08-29 17:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (167.24 KB, image/png)
2018-08-27 17:06 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-08-27 17:06:34 UTC
Created attachment 114639 [details]
screenshot

Open Discover, click "Update" in the side bar, click "Check for updates" button.
See my screenshot: "Check for updates" button is disabled but "Update all" remains enabled while Discover checks for updates.
Reproducible on both Arch Linux (Discover 5.13.4) and neon dev unstable.
Comment 1 Nate Graham 2018-08-28 19:38:43 UTC
Yep.
Comment 2 Nate Graham 2018-08-28 19:54:46 UTC
It *looks* like it just needs "&& !ResourcesModel.isFetching" appended to the condition governing its enabled: property, but I tried that and it didn't work...
Comment 3 Aleix Pol 2018-08-29 16:26:37 UTC
I tried and it worked for me. I'll submit the fix and then make sure it works for you too.
Comment 4 Aleix Pol 2018-08-29 16:27:41 UTC
Git commit 2bd91b93357318c4f7dd96b2f6e7a07dd74494c8 by Aleix Pol.
Committed on 29/08/2018 at 16:26.
Pushed by apol into branch 'master'.

Disable the update button when any backend is busy

Makes for a more reliable update experience.

M  +1    -1    discover/qml/UpdatesPage.qml

https://commits.kde.org/discover/2bd91b93357318c4f7dd96b2f6e7a07dd74494c8
Comment 5 Nate Graham 2018-08-29 17:33:31 UTC
Go figure, now it works for me.